EDCD / EDMarketConnector

Downloads commodity market and other station data from the game Elite: Dangerous for use with all popular online and offline trading tools.
GNU General Public License v2.0
991 stars 155 forks source link

5.9.1 Installer not setting link handling for Frontier Auth #2046

Closed Harry3528 closed 1 year ago

Harry3528 commented 1 year ago

Please check the Known Issues in case this has already been reported.

Please also check if the issue is covered in our Troubleshooting Guide. It might be something with a known work around, or where a third party (such as EDSM) is causing logging that is harmless.

Please complete the following information:

Describe the bug The installer does not set handling of the frontier auth link to connect to the program. In chrome, i get the console error message "Failed to launch 'edmc://auth?code=[REMOVED FOR PRIVACY]&state=[REMOVED FOR PRIVACY]' because the scheme does not have a registered handler." after clicking log in on the frontier web page.

Installing 5.9.0 fixes it, and I can log in and authorize.

To Reproduce Fresh install 5.9.1

Expected behavior Send auth data to the program after I log in and authenticate.

Additional info: This was my first time installing the program, so people just updating will probably not encounter this issue.

Rixxan commented 1 year ago

I think I see the problem. Need to update the installer to handle some of the registry keys. Will fix in the next version!

Razwerkz commented 1 year ago

I'm still having an issue similar to this post-update. When attempting to login, the "login" button does not seem to do anything.

Rixxan commented 1 year ago

Hmm, unfortunately, that part of the tool seem to need a little more TLC (even from before the 5.9.0 update)

Take a look at these steps and see if one of those solves it? If not let me know and we can go from there.

https://github.com/EDCD/EDMarketConnector/wiki/Troubleshooting#problems-with-frontier-authentication

@Razwerkz

Razwerkz commented 1 year ago

I was able to use the localserver-auth.bat file and authenticate. Thanks!