EDCD / EDMarketConnector

Downloads commodity market and other station data from the game Elite: Dangerous for use with all popular online and offline trading tools.
GNU General Public License v2.0
988 stars 155 forks source link

Bug: The drop-down menus in the settings are shown completely white when the dark theme is set #2206

Closed GLWine closed 5 months ago

GLWine commented 5 months ago

Basic nformation:

Describe the bug When the EDMC theme is set to dark, there are problems with the visibility of some items. In the settings in the drop-down menus that concern EDMC (excluding plug-ins) these are loaded completely in white and are visible only when the cursor passes over the elements.

To Reproduce

  1. Go to settings, to the appearance tab
  2. Set the dark theme
  3. Click on the OK button
  4. Reopen settings
  5. Go to the Coriolis tab
    1. Open the drop-down menu (beta/nomal)
    2. The texts will be white on a white background
    3. When you hover the cursor, the background turns black on the selected item.
  6. Go to the Configuration tab
    1. Open the any drop-down menu
    2. The texts will be white on a white background
    3. When you hover the cursor, the background turns black on the item
  7. Go to the Appearance tab
    1. Open the Language drop-down menu
    2. The texts will be white on a white background
    3. When you hover the cursor, the background turns black on the item

Expected behavior When the theme is set to dark, since the settings do not change they themselves become dark, the drop-down menus must not be affected. They will then have to show the objects in gold so that there is black text on a white background..

Screenshots image image image image image image

Rixxan commented 5 months ago

Unable to validate with EDMC 5.10.4+3b2f37f image image image

Rixxan commented 5 months ago

Can you test if this problem persists without plugins? Trying to determine where the issue might be.

GLWine commented 5 months ago

I have to test two specific plugins. The two plugins are ED Recon and BGS-Tally

However I also installed 3 others, EDMC Hits, EDMC ATEL and EDMC HourlyIncome.

However I think they are less likely.

GLWine commented 5 months ago

I confirm it is a bug between EDMC and ED Recon. When EDR is not present it does not cause problem.

Rixxan commented 5 months ago

Interesting, thanks for the follow-up!

@lekeno you may be interested in taking a look at this one (though I would encourage you to open a bug report with EDR, @glwine)

Will be closing this as a bug with EDR, not EDMC. If further information comes to light that it's something with EDMC itself, please feel free to reopen :)

lekeno commented 5 months ago

The issue should be fixed in the next release.