This PR adds additional robust checking to make sure that a ship name is not in the Windows Reserved Filename list. This removes the older self-maintained version, and dumps the responsibility for that on Python's Pathlib module. (Why replicate existing work?)
This slightly renames how ship names can be output, however, remains safe for use in Windows and Linux (Linux will accept any filename).
Type of Change
Feature Enhancement
How Tested
Tested on a number of ship names using Windows reserved naming schemes. (Hello con, the Adder!)
Description
This PR adds additional robust checking to make sure that a ship name is not in the Windows Reserved Filename list. This removes the older self-maintained version, and dumps the responsibility for that on Python's Pathlib module. (Why replicate existing work?)
This slightly renames how ship names can be output, however, remains safe for use in Windows and Linux (Linux will accept any filename).
Type of Change
How Tested
Tested on a number of ship names using Windows reserved naming schemes. (Hello con, the Adder!)
Notes
Resolves #1268