search

EDCD / EDMarketConnector

Downloads commodity market and other station data from the game Elite: Dangerous for use with all popular online and offline trading tools.
GNU General Public License v2.0
988 stars 155 forks source link

[830] Open Log Folder Natively #2226

Closed Rixxan closed 4 months ago

Rixxan commented 5 months ago

Description

Currently, when choosing "Open Plugin Location" on Linux, the system calls the web-browser and instead opens the directory in the web-browser instead of the file explorer. This is sub-optimal. Instead of calling the web-browser, this PR instructs the OS to open the file or folder indicated natively.

This is done by leveraging the help_open_log_folder() function (renamed to open_folder()), and generalizing the file. The existing help_open_log_folder() is deprecated and slated for removal in 6.0.

Type of Change

How Tested

Notes

Resolves #830

chennin commented 4 months ago

I tested this and it works on Arch Linux in Cinnamon DE :+1: