EDCD / EDMarketConnector

Downloads commodity market and other station data from the game Elite: Dangerous for use with all popular online and offline trading tools.
GNU General Public License v2.0
988 stars 155 forks source link

Potential Issues with Jump Range Calculations in edshipyard.export #2229

Open Rixxan opened 4 months ago

Rixxan commented 4 months ago

Describe the bug EDMC may be calculating and outputting laden and unladen ranges incorrectly compared to the values provided in-game. It is unclear why these are the way that they are, and should be investigated to determine where the fault is being introduced. (My guess is with the multiplier calculation)

To Reproduce Steps to reproduce the behavior:

Expected behavior A clear and concise description of what you expected to happen.

Screenshots image

Rixxan commented 4 months ago

OK so first detail: laden and unladedn per EDMC are not the same as the game's. In EDMC laden == max fuel load + max cargo, where unladen == max fuel load with no cargo. This does not take into account various fuel states beyond maximum.

Athanasius commented 4 months ago

Indeed, this EDMC code is never going to take into account "actual current fuel load", because that would be a Status.json thing and it's only taking into account the pure loadout.

There's also the wrinkle, and I forget what the game does wrt, about the Active Fuel Reservoir fuel mass.