search

EDCD / EDMarketConnector

Downloads commodity market and other station data from the game Elite: Dangerous for use with all popular online and offline trading tools.
GNU General Public License v2.0
988 stars 155 forks source link

Styling issues with tkinter 8.6.14 #2235

Open der-eismann opened 4 months ago

der-eismann commented 4 months ago

Describe the bug Recently tkinter 8.6.14 was released. I tried updating it for the Flatpak version of EDMC (see https://github.com/flathub/io.edcd.EDMarketConnector/pull/42), however some parts of the styling was off. I don't have any idea how this works and I don't know when this version would be included in "normal" Python distributions, but it might make sense to investigate this. Maybe you can give me a hint where to start? Or is it obsolete because of #2116? In this case URLs are just way larger and also hovering Ship, System & Station on the main screen will cause the layout to change since the font size increases when being hovered.

To Reproduce Steps to reproduce the behavior:

  1. Run with tkinter 8.6.14

Expected behavior Consistent style as was before

Screenshots

tkinter 8.6.13: Bildschirmfoto vom 2024-05-13 20-15-12

tkinter 8.6.14: Bildschirmfoto vom 2024-05-13 20-16-11

der-eismann commented 4 months ago

Opened this issue over at the tcl/tk repo: https://core.tcl-lang.org/tk/tktview/8162e9b7a90465f0b2a761c9515dfbc45d4b7e9f Maybe it's a Linux issue, maybe it's just because of my 200% display scaling, let's see.

dvdmuckle commented 4 months ago

For what it's worth, this doesn't happen on my machine, and I'm not using any scaling. I can test on my laptop that does have 200% scaling, but it sounds like that might be the cause.

Rixxan commented 4 months ago

Given this is likely an upstream issue with TCL/TK, marking as such. Will monitor until TCL/TK either kicks it back or fixes it.

der-eismann commented 4 months ago

For what it's worth, this doesn't happen on my machine, and I'm not using any scaling. I can test on my laptop that does have 200% scaling, but it sounds like that might be the cause.

Did you test this build? Would be great if you could test it on another device :slightly_smiling_face: I guess we could implement a workaround, but let's see what TCL/TK does first.

Rixxan commented 4 months ago

@der-eismann The TCL team seems to have closed the ticket - is the latest version of TCL/TK working? E: They haven't pushed .15 yet so we still have to wait I guess

Rixxan commented 5 days ago

@dvdmuckle @der-eismann Does the latest version fix it? It looks like they pushed .15

dvdmuckle commented 5 days ago

Gonna start on testing this now, will let you know if this fixes things tomorrow.

dvdmuckle commented 5 days ago

So I just tested EDMC 5.12.0 with 8.6.15 of tkinter, and while I never had this particular error before, everything seems to be functional. Here's the PR with those changes for the Flatpak https://github.com/flathub/io.edcd.EDMarketConnector/pull/55

dvdmuckle commented 4 days ago

For the sake of additional testing I'm going to revert the tkinter changes in the aforementioned PR and put those into a new branch to let @der-eismann test those as I can replicate the issue in this PR. Once that's done, I'll merge in the 5.12.0 release for the Flatpak.