Closed Rixxan closed 3 months ago
Athanasius
commented
4 months ago If it doesn't already ... why not make scripts/find_localised_strings.py have different exit status that can be used ? 0 for no issues found, 1 for some other state, 2 if there is a different other state, etc ?
Sure, you want to use the output if not empty here, but there might be other uses cases that would benefit from that more programmatic way to test the result of running the script.
Rixxan
commented
4 months ago If it doesn't already ... why not make
scripts/find_localised_strings.pyhave different exit status that can be used ? 0 for no issues found, 1 for some other state, 2 if there is a different other state, etc ?Sure, you want to use the output if not empty here, but there might be other uses cases that would benefit from that more programmatic way to test the result of running the script.
Good idea. Implemented.
Description
This PR adds a check to pushes to ensure that there are no missing translations, unused translations, or other out-of-date strings in the translation system. This check runs on every push.
Type of Change
Feature Enhancement
How Tested
Tested by breaking and fixing translations and testing output on pushes in a test branch. And screaming at bash. Lots of screaming at bash. See: https://github.com/HullSeals/EDMarketConnector/actions/runs/9278648668/job/25529983265 https://github.com/HullSeals/EDMarketConnector/actions/runs/9278611138/job/25529891228
Notes
Resolves #1469