EDCD / EDMarketConnector

Downloads commodity market and other station data from the game Elite: Dangerous for use with all popular online and offline trading tools.
GNU General Public License v2.0
988 stars 155 forks source link

[2251] Fix FDevID Update Paths #2253

Closed Rixxan closed 3 months ago

Rixxan commented 3 months ago

Description

This PR fixes an issue that could occur when non-installer distributions running in locations where the running users can't write to couldn't pull and update their FDEVID files. This alters the system to write to the same general location as the Plugins folder is located, as well as run the fdevid updater on startup.

This also adapts the function to accept a "local" argument to try and force the program to update the files at the same location as the program itself, such as for builds or for backward compatibility (although backward compatibility with the FDEVID files has never been guaranteed).

Also adds a sanity check to the addcommodity function just as a quick safety net.

Type of Change

Fix

How Tested

Tested with the EDCD Discord including several Linux developers who pointed out this issue.

Notes

Closes #2251.