EDCD / EDMarketConnector

Downloads commodity market and other station data from the game Elite: Dangerous for use with all popular online and offline trading tools.
GNU General Public License v2.0
987 stars 155 forks source link

Minimize to Tray broken in 5.11.1 #2256

Closed Rixxan closed 1 week ago

Rixxan commented 3 weeks ago

Please complete the following information:

EDMC Version:

OS Details:

Environment Details

Describe the bug

In 5.11.1, a handover occurred from the older/out of date infi.systray to a more updated fork, simplesystray. This worked for the most part, however, a few edge cases showed this fork was not as drop-in a replacement as we were lead to believe.

Notably, the open_window function to deiconify EDMC via the tray now requires 2 arguments, systray and an "id" value which is not well documented but defaults to 1023.

To Reproduce Steps to reproduce the behavior:

  1. Open EDMC
  2. Minimize, with the system tray enabled
  3. Right-Click "Open" or double-click on the tray icon
  4. EDMC does not re-open

Expected behavior EDMC should reopen when this button is selected.

Additional context This is a blocking error for any user who minimizes to systray. Please Confirm the Following...

Logs EDMarketConnector-debug.log debuglog.txt