Commodity market updates from CAPI in Live-Horizons in some cases produce messages with horizons: false, odyssey: false. Often seen at fleet carriers and planetary outposts, not at space stations.
It looks like capi_is_horizons() incorrectly returns false when a station offers no ships or modules and has no Colony economy?
I don't quite follow the logic, tbh.
To Reproduce
Log into Horizons (Live)
Dock to a fleet carrier
Often, this already produces a market message with horizons: false
Re-log
That reliably produces a Location message with horizons: true and a market update with horizons: false
Updating market.json produces a message with the correct flags
Additional context
Messages after logging into Horizons while docked at a carrier.
Location:
It looks like capi_is_horizons wasn't updated for the universe split or for carriers. I wonder if there are any cases even in the legacy universe where someone can have no access to Horizons?
Please complete the following information:
Commodity market updates from CAPI in Live-Horizons in some cases produce messages with
horizons: false, odyssey: false
. Often seen at fleet carriers and planetary outposts, not at space stations.It looks like capi_is_horizons() incorrectly returns false when a station offers no ships or modules and has no Colony economy? I don't quite follow the logic, tbh.
To Reproduce
Additional context
Messages after logging into Horizons while docked at a carrier. Location:
Market update from CAPI with both flags set to false:
Correct flags on event from local file:
Market update at a station with shipyard and outfitting:
Please Confirm the Following...