search

EDCD / EDMarketConnector

Downloads commodity market and other station data from the game Elite: Dangerous for use with all popular online and offline trading tools.
GNU General Public License v2.0
992 stars 155 forks source link

Inara plugin attempts to send empty/zero Major Reputation #581

Closed Athanasius closed 3 years ago

Athanasius commented 4 years ago

After filling in Inara API Key for new second account I saw this on the EDMC status line:

Error: Inara setCommanderReputationMajorFaction, No reputation value provided.

The code should check this and just not attempt to send.

Athanasius commented 4 years ago

Update https://github.com/EDCD/EDMarketConnector/wiki/New-user-guide when fixed.

Athanasius commented 3 years ago

The Journal event is literally just:

{ "timestamp":"2021-04-05T11:00:55Z", "event":"Reputation" }

This means monitor.state['Reputation'] has likely all zeroes. So catch that and don't try to send the zeroes.

Athanasius commented 3 years ago

Fix will be in 5.0.0-beta5.