search

EDCD / EDMarketConnector

Downloads commodity market and other station data from the game Elite: Dangerous for use with all popular online and offline trading tools.
GNU General Public License v2.0
991 stars 155 forks source link

Crashing On Startup #798

Closed Jukebox-Zulu closed 3 years ago

Jukebox-Zulu commented 3 years ago

EDMC simply seems to not visibly start at all. From what I can tell there is no zombie process running. Problem still occurs after a PC restart and full uninstall and re-install of the latest version of EDMC. Have removed all plugins from the folder to no effect. It seems like this has been an issue for at least around a month as my last posted flight log to EDSM was in October.

EDMarketConnector.log EDMarketConnector-debug.log

A-UNDERSCORE-D commented 3 years ago

This is weird. You have a stack trace which points at python stdlib code. 

Traceback (most recent call last):
  File "EDMarketConnector.py", line 1112, in <module>
  File "EDMarketConnector.py", line 1066, in log_locale
  File "logging\__init__.pyc", line 1366, in debug
  File "logging\__init__.pyc", line 1514, in _log
  File "logging\__init__.pyc", line 1523, in handle
  File "logging\__init__.pyc", line 751, in filter
  File "EDMCLogging.pyc", line 255, in filter
  File "EDMCLogging.pyc", line 287, in caller_attributes
  File "inspect.pyc", line 1464, in getframeinfo
  File "inspect.pyc", line 828, in findsource
IndexError: list index out of range

Either they broke something or something we did breaks that. But that seems VERY strange. If you're comfortable doing it, try running from source and see if the issue persists.

Athanasius commented 3 years ago

@Jukebox-Zulu Do you have any Anti-Virus and/or Software Firewall installed ?

EDMC uses its own copy of Python, and this works on plenty of other systems, there has to be something different about your system causing this internal Python code (we're trying to use standard Python calls to walk the call stack in order to get extra information for identifying where some logging was done) to fail.

Athanasius commented 3 years ago

@Jukebox-Zulu could you try the new release that we made today, 4.1.5 ? This might work around the problem, or might just reveal that things are even more broken and still not run, either way the EDMarketConnector.log will offer more information. Thanks!

It would also be useful to know:

  1. The exact version of Windows you're using (this will be in the log file if 4.1.5 appears to work for you, else check System > About in the Windows 10 settings).
  2. What CPU you're running on (as exact as you can manage, again, System > About can help with this).
  3. Any Anti-Virus, Firewall or VPN software you're using.
Jukebox-Zulu commented 3 years ago

Athanasius,

Thanks for the quick response! I'm happy to report that the latest update has EDMC working for me again. sys.getwindowsversion returns: (major=10, minor=0, build=19041, platform=2, service_pack='') Running on an Intel i5-8400 No 3rd party anti-virus, using NordVPN but generally have it disabled while I run Elite as they don't always play nice.

Hope that's helpful in the future! Love the utility, and thank you for your work.

Wish you the best, Juke

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Tuesday, December 15, 2020 2:42 PM, Athanasius notifications@github.com wrote:

@Jukebox-Zulu could you try the new release that we made today, 4.1.5 ? This might work around the problem, or might just reveal that things are even more broken and still not run, either way the EDMarketConnector.log will offer more information. Thanks!

It would also be useful to know:

  • The exact version of Windows you're using (this will be in the log file if 4.1.5 appears to work for you, else check System > About in the Windows 10 settings).
  • What CPU you're running on (as exact as you can manage, again, System > About can help with this).
  • Any Anti-Virus, Firewall or VPN software you're using.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

Athanasius commented 3 years ago

@Jukebox-Zulu

It's excellent to hear that EDMC is now working for you, but ...

... could you please attach your latest EDMarketConnector.log to a reply so we can see if this is our workaround in action, or if 4.1.5 is simply working normally for you. Thanks.

Jukebox-Zulu commented 3 years ago

Here you go!

Sent with ProtonMail Secure Email.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Monday, December 21, 2020 3:08 AM, Athanasius notifications@github.com wrote:

@Jukebox-Zulu

It's excellent to hear that EDMC is now working for you, but ...

... could you please attach your latest EDMarketConnector.log to a reply so we can see if this is our workaround in action, or if 4.1.5 is simply working normally for you. Thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. 2020-12-21 13:35:24.365 - INFO - EDMarketConnector.main:1233: Startup v4.1.5 : Running on Python v3.7.9 (tags/v3.7.9:13c94747c7, Aug 17 2020, 18:01:55) [MSC v.1900 32 bit (Intel)] 2020-12-21 13:35:24.381 - DEBUG - EDMarketConnector.main:1238: Platform: win32 sys.getwindowsversion(major=10, minor=0, build=19041, platform=2, service_pack='') argv[0]: EDMarketConnector.exe exec_prefix: executable: C:\Program Files (x86)\EDMarketConnector\EDMarketConnector.exe sys.path: ['C:\Program Files (x86)\EDMarketConnector\library.zip'] EDMCLogging:EDMCContextFilter:caller_attributes(): Failed in inspect.getframinfo(frame) frame: <frame at 0x035D6CB0, file 'EDMarketConnector.py', line 1203, code log_locale> 2020-12-21 13:35:24.382 - DEBUG - ??.??:1203: Locale: Initial Locale Locale LC_COLLATE: ('English_United States', 'utf8') Locale LC_CTYPE: ('English_United States', 'utf8') Locale LC_MONETARY: ('English_United States', 'utf8') Locale LC_NUMERIC: ('English_United States', 'utf8') Locale LC_TIME: ('English_United States', 'utf8') EDMCLogging:EDMCContextFilter:caller_attributes(): Failed in inspect.getframinfo(frame) frame: <frame at 0x035D6E40, file 'EDMarketConnector.py', line 1203, code log_locale> 2020-12-21 13:35:24.382 - DEBUG - ??.??:1203: Locale: After LC_ALL defaults set Locale LC_COLLATE: ('English_United States', 'utf8') Locale LC_CTYPE: ('English_United States', 'utf8') Locale LC_MONETARY: ('English_United States', 'utf8') Locale LC_NUMERIC: ('English_United States', 'utf8') Locale LC_TIME: ('English_United States', 'utf8') 2020-12-21 13:35:24.383 - DEBUG - EDMarketConnector.main:1261: Locale LC_CTYPE: ('English_United States', 'utf8') EDMCLogging:EDMCContextFilter:caller_attributes(): Failed in inspect.getframinfo(frame) frame: <frame at 0x03609030, file 'EDMarketConnector.py', line 1203, code log_locale> 2020-12-21 13:35:24.386 - DEBUG - ??.??:1203: Locale: After switching to UTF-8 encoding (same language) Locale LC_COLLATE: ('English_United States', 'utf8') Locale LC_CTYPE: ('English_United States', 'utf8') Locale LC_MONETARY: ('English_United States', 'utf8') Locale LC_NUMERIC: ('English_United States', 'utf8') Locale LC_TIME: ('English_United States', 'utf8') E:D Market Connector 4.1.5 2020-12-21 13:35:24.468 - INFO - plug.Plugin.init:98: loading plugin "coriolis" from "C:\Program Files (x86)\EDMarketConnector\plugins\coriolis.py" 2020-12-21 13:35:24.470 - INFO - plug.Plugin.init:98: loading plugin "eddb" from "C:\Program Files (x86)\EDMarketConnector\plugins\eddb.py" 2020-12-21 13:35:24.471 - INFO - plug.Plugin.init:98: loading plugin "eddn" from "C:\Program Files (x86)\EDMarketConnector\plugins\eddn.py" 2020-12-21 13:35:24.472 - INFO - plug.Plugin.init:98: loading plugin "edsm" from "C:\Program Files (x86)\EDMarketConnector\plugins\edsm.py" 2020-12-21 13:35:24.474 - INFO - plug.Plugin.init:98: loading plugin "edsy" from "C:\Program Files (x86)\EDMarketConnector\plugins\edsy.py" 2020-12-21 13:35:24.475 - INFO - plug.Plugin.init:98: loading plugin "inara" from "C:\Program Files (x86)\EDMarketConnector\plugins\inara.py" 2020-12-21 13:35:24.479 - INFO - plug.Plugin.init:98: loading plugin "EDMC_SpanshRouter_310" from "C:\Users\bradt\AppData\Local\EDMarketConnector\plugins\EDMC_SpanshRouter_310\load.py" No previously saved route. 2020-12-21 13:35:24.702 - INFO - monitor.EDLogs.start:177: Monitoring Journal Folder: "C:\Users\bradt\Saved Games\Frontier Developments\Elite Dangerous" 2020-12-21 13:35:24.703 - INFO - monitor.EDLogs.start:178: Start Journal File: "C:\Users\bradt\Saved Games\Frontier Developments\Elite Dangerous\Journal.201219184057.01.log" 2020-12-21 13:35:24.704 - DEBUG - monitor.EDLogs.start:181: Starting Journal worker 2020-12-21 13:35:24.705 - DEBUG - monitor.EDLogs.worker:235: Starting on logfile "C:\Users\bradt\Saved Games\Frontier Developments\Elite Dangerous\Journal.201219184057.01.log" 2020-12-21 13:35:25.061 - DEBUG - companion.Session.login:412: changed account or retrying login during auth 2020-12-21 13:35:25.062 - DEBUG - companion.Auth.refresh:231: Trying for "JukeboxZulu" 2020-12-21 13:35:25.063 - DEBUG - companion.Auth.refresh:235: Cmdrs: ['JukeboxZulu'] 2020-12-21 13:35:25.064 - DEBUG - companion.Auth.refresh:238: idx = 0 2020-12-21 13:35:25.064 - DEBUG - companion.Auth.refresh:243: We have a refresh token for that idx 2020-12-21 13:35:25.065 - DEBUG - companion.Auth.refresh:250: Attempting refresh with Frontier... 2020-12-21 13:35:25.871 - DEBUG - companion.Session.login:422: We have an access_token 2020-12-21 13:35:25.872 - DEBUG - companion.Session.start:455: Starting session EDMCLogging:EDMCContextFilter:caller_attributes(): Failed in inspect.getframinfo(frame) frame: <frame at 0x0541A610, file 'EDMarketConnector.py', line 1066, code onexit> 2020-12-21 13:36:21.975 - INFO - ??.??:1066: Starting shutdown procedures... EDMCLogging:EDMCContextFilter:caller_attributes(): Failed in inspect.getframinfo(frame) frame: <frame at 0x0541A610, file 'EDMarketConnector.py', line 1068, code onexit> 2020-12-21 13:36:21.976 - INFO - ??.??:1068: Closing protocol handler... EDMCLogging:EDMCContextFilter:caller_attributes(): Failed in inspect.getframinfo(frame) frame: <frame at 0x0541A610, file 'EDMarketConnector.py', line 1071, code onexit> 2020-12-21 13:36:21.976 - INFO - ??.??:1071: Unregistering hotkey manager... EDMCLogging:EDMCContextFilter:caller_attributes(): Failed in inspect.getframinfo(frame) frame: <frame at 0x0541A610, file 'EDMarketConnector.py', line 1074, code onexit> 2020-12-21 13:36:21.978 - INFO - ??.??:1074: Closing dashboard... EDMCLogging:EDMCContextFilter:caller_attributes(): Failed in inspect.getframinfo(frame) frame: <frame at 0x0541A610, file 'EDMarketConnector.py', line 1077, code onexit> 2020-12-21 13:36:21.978 - INFO - ??.??:1077: Closing journal monitor... EDMCLogging:EDMCContextFilter:caller_attributes(): Failed in inspect.getframinfo(frame) frame: <frame at 0x0541A610, file 'EDMarketConnector.py', line 1080, code onexit> 2020-12-21 13:36:22.352 - INFO - ??.??:1080: Notifying plugins to stop... 2020-12-21 13:36:22.822 - INFO - monitor.EDLogs.worker:343: We're not meant to be running, exiting... No route to delete EDMCLogging:EDMCContextFilter:caller_attributes(): Failed in inspect.getframinfo(frame) frame: <frame at 0x0541A610, file 'EDMarketConnector.py', line 1083, code onexit> 2020-12-21 13:36:22.953 - INFO - ??.??:1083: Closing update checker... EDMCLogging:EDMCContextFilter:caller_attributes(): Failed in inspect.getframinfo(frame) frame: <frame at 0x0541A610, file 'EDMarketConnector.py', line 1086, code onexit> 2020-12-21 13:36:22.954 - INFO - ??.??:1086: Closing Frontier CAPI sessions... EDMCLogging:EDMCContextFilter:caller_attributes(): Failed in inspect.getframinfo(frame) frame: <frame at 0x0541A610, file 'EDMarketConnector.py', line 1089, code onexit> 2020-12-21 13:36:22.955 - INFO - ??.??:1089: Closing config... EDMCLogging:EDMCContextFilter:caller_attributes(): Failed in inspect.getframinfo(frame) frame: <frame at 0x0541A610, file 'EDMarketConnector.py', line 1092, code onexit> 2020-12-21 13:36:22.955 - INFO - ??.??:1092: Destroying app window... EDMCLogging:EDMCContextFilter:caller_attributes(): Failed in inspect.getframinfo(frame) frame: <frame at 0x0541A610, file 'EDMarketConnector.py', line 1095, code onexit> 2020-12-21 13:36:23.018 - INFO - ??.??:1095: Done. 2020-12-21 13:36:23.018 - INFO - EDMarketConnector.main:1364: Exiting

Athanasius commented 3 years ago

Thanks. So, it seems to literally only have an issue with looking up things for EDMarketConnector.py, not for any of our other source files.

The difference there is that EDMarketConnector.py is baked into the .exe, all other files are in library.zip as a .pyc file. I wonder if a 'full' workaround would be to ship a copy of EDMarketConnector.py in the zip ? But then why does this work perfectly fine on so many other systems ?