search

EDCD / coriolis

Coriolis Shipyard for Elite Dangerous
https://coriolis.io
Other
262 stars 83 forks source link

Support importing SLEF json #142

Closed HittingSmoke closed 4 years ago

HittingSmoke commented 7 years ago

https://github.com/cmmcleod/coriolis/issues/72

It seems this was implemented by the previous devs but is not currently working. Copy/pasting an EDShipyard export into the Coriolis import field gives a "Cannot Parse The Data" error.

strideynet commented 7 years ago

71 Turns out this was a hidden bug. Thanks for reporting.

bionicvapourboy commented 6 years ago

In the last days we are working to share a common public repo for EDShipyard

https://github.com/bionicvapourboy/EDSHIPYARD

There is a lot of work to do, but in order to keep the application alive we need users to contribute by opening issues and sending pull request.

felixlinker commented 5 years ago

Most concise way to export builds in edsy currently is via a SLEF json that was recently added to inara. coriolis should support this event.

FX-Wood commented 4 years ago

I came upon this while trying to import a ship build from Inara.cz via a SLEF export. The error message I got was:

Build Name Missing!

After chit-chatting for a bit in the coriolis-orbis discord channel, I was enlightened with a workaround (thank you alterNERDtive):

  1. Login/sign-up for edsm.net
  2. Allow/force fleet to update
  3. Navigate to ship you want to export
  4. Click on green "see ship details" button
  5. Choose either coriolis or E:D shipyard for export

It worked great for getting my existing fleet into coriolis.

I would be willing and eager to write a PR that would allow for importing SLEF formatted json. Any interest?

clinkingdog commented 4 years ago

Does this also cover exporting in SLEF format? I'd really like to enable Inara's "compare loadouts" function between current and target loadouts, and that only works with SLEF format.

[Edited - sorry, misrepresented the issue the first time]

(If this issue is only for import, is it ok if I raise a separate issue for export?)