EDCD / coriolis

Coriolis Shipyard for Elite Dangerous
https://coriolis.io
Other
262 stars 82 forks source link

AX Missile Rack Class 1 Missing #674

Closed felixlinker closed 4 months ago

alterNERDtive commented 3 years ago

There is no class 1 AX missile rack, just an advanced missile rack.

robertpateii commented 3 years ago

^ confirmed, my mistake. The class 1 and class 2 advanced missile rack that are missing, along with the class 1 and class 2 advanced multicannon. (There's no class 3+ for either according to eddb https://eddb.io/archive/v6/modules.json.) This causes imports from edmc to fail and likely other sources, and the stats at least for the missle racks are slightly different than regular.

felixlinker commented 3 years ago

^ confirmed, my mistake. The class 1 and class 2 advanced missile rack that are missing, along with the class 1 and class 2 advanced multicannon. (There's no class 3+ for either according to eddb https://eddb.io/archive/v6/modules.json.) This causes imports from edmc to fail and likely other sources, and the stats at least for the missle racks are slightly different than regular.

The issue then is that imports fail? Because to my knowledge, it's the same as the standard missile rack but with advanced synthesis options.

robertpateii commented 3 years ago

There's really two issues, with a third one I noticed while debugging this.

  1. Advanced missile racks are not in coriolis, and have 64 ammo maximum, higher than standard missile racks. Other stats are the same. Advanced multicannons are the same as regular.
  2. EDMC import is failing when I have an engineered advanced missile rack equipped (unengineered versions are simply ignored)
  3. All multicannon falloff is 2km not 1.8km as shown on coriolis

image image

felixlinker commented 3 years ago

Could you open a new issue for point 3? Thanks for reporting!

robertpateii commented 3 years ago

Done. #678 . Reminder that the title of this ticket is wrong, should be "Advanced Missile Racks and Advanced Multicannons missing and when engineered explode on import" or something

alex-williams commented 4 months ago

Advanced Missile Racks do now exist in Coriolis, can this issue be closed?

felixlinker commented 4 months ago

Cheers for pointing that out