search

EDCD / coriolis

Coriolis Shipyard for Elite Dangerous
https://coriolis.io
Other
262 stars 82 forks source link

Inconsistent power capacity display #710

Open chennin opened 1 year ago

chennin commented 1 year ago

Take this build: https://coriolis.io/outfit/anaconda?code=A0pktpFklndxsxf5--------0202------3h1111-1Ofr4a-v49e03-2i.AwRj4yvZUuRA.Aw18ZXEA..EweloBhBmSQUwIYHMA28QgIwVyKBQA%3D%3D

And open the power plant menu and note how the 5A is NOT red. Then select the 5A, and notice how the top bar, and the power display below, turn red.

Expected: The 5A to be red (when not selected); or if the 5A is actually enough power, for the top bar & below power bar to not be red when the 5A is selected.

I do not know which is correct as I have not tested it ingame.

Browser: Firefox 105.0.3 (64-bit), OS: Arch Linux on 2022-10-10. Also in Chrome 106.0.5249.103 on the same OS.

Sid127 commented 1 year ago

Looked into it, seems to be an edge case when rounding things off. I will address this soon, thank you for the report!

alex-williams commented 3 months ago

I don't see this as an issue, the plant literally produces just the same amount of power as is being consumed by the ship, with certain modules disabled, rounding causes it to go red instead of just being inside the usable zone as the selection indicates, but if more modules are turned off and/or the plant is engineered, it produces more than enough power. I don't think this is an issue, because the game will let you fit this module, it will just turn modules off due to lack of power, which is expected behaviour. You would then be expected in game, just as you are in coriolis, to either turn modules off, change the priorities of the modules to cope with the lack of power, engineer the powerplant to make more power, engineer other modules to make less power, or both...

chennin commented 3 months ago

The issue is in the inconsistent display on Coriolis. I expected both places to be red or both to not be. But right now one is and one isn't.

alex-williams commented 3 months ago

The issue is in the inconsistent display on Coriolis. I expected both places to be red or both to not be. But right now one is and one isn't.

Actually, looking at it, Coriolis will let you fit the red modules too in the selection stage, so yes, there is an issue.