EDCD / coriolis

Coriolis Shipyard for Elite Dangerous
https://coriolis.io
Other
262 stars 82 forks source link

Export function for Inara build station search adds default modules to the search #756

Open alex-williams opened 4 months ago

alex-williams commented 4 months ago

When using the 'stations that sell this build' link to Inara at the top of Coriolis, the link generates a search on Inara that includes modules which are default for the ship, such as default armour, default FSD, default fuel tank, etc. This is inefficient, as in game, stations which sell a ship, may not sell the default modules for the ship... this leads to Inara ignoring stations which sell the ship and the upgraded modules the user actually wants, but doesn't sell the default modules that the user doesn't need to buy anyway. The export link construction needs to be done in such a way, that it checks the build against the ship template for default modules and leaves them out if they are in the build. No one needs to look for a default module, as in the event that someone does actually want to return a ship to stock, at least in the case of core modules, removing the upgrade in any outfitting, in any station, regardless of whether the station sells that default module or not, causes the default module to be purchased and installed on the ship.