EDDiscovery / EDDLite

Elite Dangerous Discovery Lite - Journal reader, Inara/EDSM/EDDN/Corolis/EDSY integration
Apache License 2.0
38 stars 5 forks source link

2.1.0.0: EDDN: approachsettlement/1 messages have Name_Localised, should be stripped. #10

Closed Athanasius closed 2 years ago

Athanasius commented 2 years ago

As per https://github.com/EDDiscovery/EDDiscovery/issues/3237, now EDDLite has been observed trying to send Name_Localised in approachsettlement/1 messages:


2022-04-28 17:50:09,750 - ERROR - Gateway:274: Failed Validation "[<ValidationError: "Additional properties are not allowed ('Name_Localised' was unexpected)">]" (536, "EDDLite", "2.1.0.0", "https://eddn.edcd.io/schemas/approachsettlement/1", "-") from <source ip>
2022-04-28 18:31:47,959 - ERROR - Gateway:274: Failed Validation "[<ValidationError: "Additional properties are not allowed ('Name_Localised' was unexpected)">]" (535, "EDDLite", "2.1.0.0", "https://eddn.edcd.io/schemas/approachsettlement/1", "-") from <source ip>
2022-04-29 05:35:22,679 - ERROR - Gateway:274: Failed Validation "[<ValidationError: "Additional properties are not allowed ('Name_Localised' was unexpected)">]" (535, "EDDLite", "2.1.0.0", "https://eddn.edcd.io/schemas/approachsettlement/1", "-") from <source ip>
Eahlstan commented 2 years ago

Seems like Robby didn't update the Core when compiling. It's currently on 1a2313c which has this version of the EDDN code. This thing is missing the code that strips localised things.

The current version has the required line:

RemoveCommonKeys(message); // remove _localised

robbyxp1 commented 2 years ago

Doh!

Fixed, 2.2