EDDiscovery / EliteDangerousCore

Elite Dangerous specific submodule
Apache License 2.0
2 stars 18 forks source link

Add megaship classification to FSS signals #113

Closed Eahlstan closed 1 year ago

Eahlstan commented 1 year ago

I don't like the DisplayNote thing, I just put it there for now so those signals don't get lost

robbyxp1 commented 1 year ago

I'd be tempted to do (outside of the function in the class)

static string[] megashipnames = new string[] { "name","name",.. };

then you can do

if ( megashipnames.ContainsIn(SignalNames, StringComparison.InvariantCultureIgnoreCase) >= 0

this always looks tidier.

robbyxp1 commented 1 year ago

Another way, it to look for -class ? Do they always follow a pattern which is different from other signal names?