EDDiscovery / EliteDangerousCore

Elite Dangerous specific submodule
Apache License 2.0
2 stars 18 forks source link

Improve third party logging (EDDN, Inara) #116

Closed Merovech closed 1 year ago

Merovech commented 1 year ago

Modified logging with a few goals in mind:

I'd like to eventually do this for all third-party integrations (IGAU, EDAstro, EDSM, etc.) but I don't have accounts on all of them and wanted to use this as sort of a test balloon to see if I should even bother -- if this gets accepted I'll start work on the others.

The impetus for this came from the fact that I was transitioning from EDMC (Elite Dangerous Market Connector) to EDDiscovery full-time. I didn't realize EDD can do everything I needed from EDMC, and when I learned that I entered my info for Inara and discovered that I couldn't tell if it actually worked or not because EDD didn't log a successful Inara send. Other integrations provide useful information along those lines, like EDDN, so I am hoping this brings some consistency to how things are logged.

Screenshot of the result, from the Log tab: image

(Really hoping I did this right; I've never worked with submodules before.)

robbyxp1 commented 1 year ago

I'll have to have a think about this, if we want the Log to be continually updated with Inara messages.. there are a log of them.

robbyxp1 commented 1 year ago

I know EDDN does a log every go (thats historical).

robbyxp1 commented 1 year ago

Thanks