EDDiscovery / EliteDangerousCore

Elite Dangerous specific submodule
Apache License 2.0
2 stars 18 forks source link

ScanInfoLine add Temperature #121

Closed Eahlstan closed 1 year ago

Eahlstan commented 1 year ago

Seem to work, not sure about the change in StarScanNode.cs though - please have a look

robbyxp1 commented 1 year ago

Looks good, except there is already a "surface temp" tx string in there..

        if (nSurfaceTemperature.HasValue)
            scanText.AppendFormat("Surface Temp: {0}K\n".T(EDCTx.JournalScan_SurfaceTemp), nSurfaceTemperature.Value.ToString("N0"));

Do we just want to use that instead?

Eahlstan commented 1 year ago

I think we'd need to rewrite the whole section to make that kind of formatting work. Right now it errors on that {0} code when using information.Append.

Screenshot 2023-04-01 110147

Also since scanText currently doesn't exist at those lines and information.Append can't handle the conversion more rewriting would be needed (I think).

Screenshot 2023-04-01 115433

Surely possible, but worth the effort?

robbyxp1 commented 1 year ago

no