EDF-Lab / BuildSysPro

BuildSysPro open source: EDF's Modelica library for buildings, districts and energy systems modelling
Other
42 stars 22 forks source link

sinh #5

Closed thorade closed 7 years ago

thorade commented 7 years ago

The model BuildSysPro/BoundaryConditions/Solar/Utilities/SineH uses sinh as a variable name, but that is also the name for the function hyperbolic sine, defined in Modelica.Math.sinh. Not sure whether that might be a problem at some point.

thorade commented 7 years ago

Same problem in

and maybe some more: https://github.com/edf-enerbat/BuildSysPro/search?utf8=%E2%9C%93&q=sinh

bcharrier commented 7 years ago

Hi @thorade Thank you for your observation. I'll change the name sinh into sin_h in all models.