BuildSysPro.BoundaryConditions.Solar.Irradiation.LightTransCoeff uses the Real equality operator outside of a function.

EDF-Lab / BuildSysPro

BuildSysPro open source: EDF's Modelica library for buildings, districts and energy systems modelling

Other

42 stars 22 forks source link

BuildSysPro.BoundaryConditions.Solar.Irradiation.LightTransCoeff uses the Real equality operator outside of a function. #9

Open qlambert-pro opened 2 years ago

qlambert-pro commented 2 years ago

BuildSysPro.BoundaryConditions.Solar.Irradiation.LightTransCoeff uses the == operator on Real values, which is illegal according to the Modelica Specification section 3.5. == can only be used to compare Reals inside functions. Let me know if you want me to try and find other occurrences of this issue.

bcharrier commented 2 years ago

Thank you @qlambert-pro for reporting this issue. Of course, further feedback on such errors will be more than welcome.

qlambert-pro commented 2 years ago

I couldn't find any other such cases by validating the examples in the library.