Support secrets in upgrade jobs

EDITD / kubetools

:nut_and_bolt: Kubetools is a tool and processes for developing and deploying microservices to Kubernetes.

MIT License

13 stars 2 forks source link

Support secrets in upgrade jobs #158

Closed tmwoodruff closed 9 months ago

tmwoodruff commented 10 months ago

Test failures are unrelated to this change. I ran into this issue a couple of weeks ago. Seems to be an issue with new versions of cython and pyaml: https://github.com/yaml/pyyaml/issues/601

Haven't had time to look into solutions.

gchazot commented 9 months ago

@tmwoodruff Just FYI I've noticed this PR and think it's interesting, but I think the problem causing the tests to fail needs to be properly resolved before progressing

tmwoodruff commented 9 months ago

@gchazot - Added fixes for the tests. This required

Adding a constraint of cython<3 for https://github.com/yaml/pyyaml/issues/601
Pinning requests and urllib3 for https://github.com/docker/docker-py/issues/3113

For https://github.com/docker/docker-py/issues/3113, we could alternatively upgrade the docker lib to 6.1.0, but that looks like a much bigger change.

gchazot commented 9 months ago

https://github.com/EDITD/kubetools/pull/159 @tmwoodruff I've extracted the dependencies fixes and documented them in a separate PR

gchazot commented 9 months ago

I've force pushed a rebase of this on top of master now that #159 was merged

gchazot commented 9 months ago

Nice one @tmwoodruff Thanks for the reviews @DilaraOflaz

I will release this now