EDITD / kubetools

:nut_and_bolt: Kubetools is a tool and processes for developing and deploying microservices to Kubernetes.
MIT License
13 stars 2 forks source link

resolve port conflicts in containers #7

Closed maapxa closed 4 years ago

maapxa commented 5 years ago

There are cases when the _create_compose_service method allocates the same port to different containers. An example is with data-curator-ec7733a2PR595-webserver and data-curator-ec7733a2PR595-redis that are both allocated port 17821

maapxa commented 5 years ago

kudos to @risktoparkrageram for discovering this :tada:

Fizzadar commented 5 years ago

So these are generated here - essentially we need a (better/new) way of turning a string into a consistent port between 1024-65536 without causing clashes (or, as few as possible).

chrissinclairedited commented 5 years ago

Other places that dynamically pick ports tend to check if the port is free, and if not then increment by 1 until they find a free port. We could probably do something similar here? Would probably mean that readme's couldn't rely on a specific port number though.

Fizzadar commented 4 years ago

I do not believe this is still an issue? Certainly not seen any recurrence in a long while...