EDIorg / EMLassemblyline

R package for creating EML metadata
https://ediorg.github.io/EMLassemblyline/
MIT License
27 stars 13 forks source link

Enable full control of data entity metadata #128

Open clnsmth opened 1 year ago

clnsmth commented 1 year ago

Currently, some data entity metadata cannot be defined by users. For example, formatName values are automatically determined within a subroutine of make_eml() and there is no mechanism to override this process. This is obviously an issue when the estimated values are incorrect, or when it's not even reasonable to approximate the values.

A possible solution is to provide an optional entities.txt template for defining entity descriptions, physical metadata, and other information that doesn't fit into the existing set of templates or which would be too onerous to supply as arguments to make_eml(). It's optional in the sense that if missing, make_eml() will continue working as it currently does, but if the template is present, make_eml() will defer to the set values defined therein.

Here's a draft of the entities template for review and comment: https://docs.google.com/spreadsheets/d/1LGuv2gauQXDwrZzYvtbYIWJN5F4uMDGRChf9FyqCbpw/edit?usp=sharing

This template will help resolve #14, #15, #45, #60, #107, #120

Thoughts?

joefutrelle commented 1 year ago

@clnsmth thanks for this. I took a look at the draft template and I have a few questions about it:

I will follow up with #45 as well.

clnsmth commented 1 year ago

Thanks for these helpful questions and comments @joefutrelle.