EDIorg / EMLassemblyline

R package for creating EML metadata
https://ediorg.github.io/EMLassemblyline/
MIT License
28 stars 13 forks source link

Development #80

Closed earnaud closed 3 years ago

earnaud commented 3 years ago

Added:

earnaud commented 3 years ago

Odd behavior: installing the fork from Github and loading EAL, it perfectly works. But {testthat} has a feature executing each test in a separate environment, which prevents from using the defined options on load.

earnaud commented 3 years ago

Weird, my local R CMD check returns me there are no errors.

codecov-io commented 3 years ago

Codecov Report

Merging #80 (4ce1c3a) into development (6423483) will decrease coverage by 1.28%. The diff coverage is 87.64%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development      #80      +/-   ##
===============================================
- Coverage        92.22%   90.93%   -1.29%     
===============================================
  Files               14       18       +4     
  Lines             2946     4403    +1457     
===============================================
+ Hits              2717     4004    +1287     
- Misses             229      399     +170     
Impacted Files Coverage Δ
R/extract_geocoverage.R 100.00% <ø> (ø)
R/validate_templates.R 92.64% <ø> (-2.78%) :arrow_down:
R/zzz.R 62.50% <62.50%> (ø)
R/annotate_eml.R 63.49% <63.49%> (ø)
R/validate_arguments.R 90.32% <86.34%> (-4.42%) :arrow_down:
R/template_categorical_variables.R 92.94% <92.85%> (-5.46%) :arrow_down:
R/template_table_attributes.R 97.47% <96.00%> (-0.31%) :arrow_down:
R/template_arguments.R 88.44% <97.50%> (+2.16%) :arrow_up:
R/make_eml.R 88.02% <98.71%> (+4.56%) :arrow_up:
R/template_annotations.R 99.54% <99.54%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update db5fcb2...4ce1c3a. Read the comment docs.

earnaud commented 3 years ago

Ok, definitely : R tests are way too long for Travis, and travais wait 30 prefix command is over-useful.