clnsmth
commented
2 years ago Test drive the proposed changes from the "dataset_format" branch.
Control return structure with the format param.
> old <- read_data("edi.193.5", format = "old")
> str(old,max.level = 2)
List of 1
$ edi.193.5:List of 3
..$ metadata :List of 1
..$ tables :List of 8
..$ validation_issues: list()
> new <- read_data("edi.193.5")
> str(new, max.level = 1)
List of 4
$ metadata :List of 1
$ tables :List of 8
$ validation_issues: list()
$ id : chr "edi.193.5"An iteration context:
> ids <- c("edi.193.5", "edi.303.2")
> old <- lapply(ids, read_data, format = "old")
List of 2
$ :List of 1
..$ edi.193.5:List of 3
.. ..$ metadata :List of 1
.. ..$ tables :List of 8
.. ..$ validation_issues: list()
$ :List of 1
..$ edi.303.2:List of 3
.. ..$ metadata :List of 1
.. ..$ tables :List of 6
.. ..$ validation_issues: list()
> new <- lapply(ids, read_data)
List of 2
$ :List of 4
..$ metadata :List of 1
..$ tables :List of 8
..$ validation_issues: list()
..$ id : chr "edi.193.5"
$ :List of 4
..$ metadata :List of 1
..$ tables :List of 6
..$ validation_issues: list()
..$ id : chr "edi.303.2"
sokole
User feedback suggests a restructuring of the dataset object, returned by
read_data(), would be helpful. Currently, the result requires a consistently verbose indexing of object attributes (i.e. requiresdataset[[i]]$), and doesn't work well in common iteration contexts (e.g.lapply()). Any new structure can be implemented in a backwards compatible way through a controllingformatargument, which defaults to the new version, but can return the old if directed.The current structure:
A proposed structure:
Comments/suggestions are welcome. Thanks!