search

EDIorg / ecocomDP

A dataset design pattern and R package for ecological community data.
https://ediorg.github.io/ecocomDP/
Other
32 stars 13 forks source link

Possible breaking change in upcoming `usmap` 0.6.0 #136

Closed pdil closed 2 years ago

pdil commented 2 years ago

I'm the maintainer of the usmap which is used in ecocomDP and wanted to warn that the next version of usmap (0.6.0 coming in the next few weeks) contains a breaking change in the usmap_transform package.

In order to provide more flexibility of input data, a new parameter (input_names) has been added to specify the longitude and latitude column names of the input data.

I found that this line in particular may require a change: https://github.com/EDIorg/ecocomDP/blob/5a919749b147635e15640af1646398f650180f30/R/plot_taxa.R#L1317

Since the data specified here: https://github.com/EDIorg/ecocomDP/blob/5a919749b147635e15640af1646398f650180f30/R/plot_taxa.R#L1311-#L1315 uses longitude and latitude column names, the usmap_transform code will have to be changed to:

transformed_cleaned <- suppressWarnings(usmap::usmap_transform(cleaned, input_names = c("longitude", "latitude")))

Note this change will only be required after 0.6.0 is released. If desired, I can notify here when that happens.

For more information, see: https://github.com/pdil/usmap/pull/53

clnsmth commented 2 years ago

Thanks for the notification @pdil.

@sokole Would you mind submitting a PR for this and the possibly related CRAN Package Check Errors? The fix needs to be on CRAN before 2022-03-13 or ecocomDP will be removed. Many thanks!

clnsmth commented 2 years ago

The fixes are in and version 1.2.1 of ecocomDP released on CRAN.