search

EDIorg / ecocomDP

A dataset design pattern and R package for ecological community data.
https://ediorg.github.io/ecocomDP/
Other
32 stars 13 forks source link

neonUtilities::getTaxonTable #153

Open daijiang opened 6 months ago

daijiang commented 6 months ago

https://github.com/EDIorg/ecocomDP/blob/ebba105b0acc522cb4296cd7f887f4980cfd7044/R/map_neon.ecocomdp.10022.001.002.R#L272 neonUtilities::getTaxonTable needs to be replaced to neonOS::getTaxonList

clnsmth commented 6 months ago

Hey @sokole. Would you be able to take a look at this issue? I'm not entirely sure if our integration tests cover it adequately.

Which reminds me, it might be a good idea for us to go over our test suite together and see if there are any adjustments we could make to be more confident in applying changes to the ecocomDP code base. What do you think?

Thanks a bunch for your help!

sokole commented 6 months ago

I made this update in the pull request last summer before ESA. The fix is in the dev branch on my fork if not already merged into the dev branch on EDIorg.

clnsmth commented 6 months ago

Heads up @sokole, I don't see @daijiang's recommended code change in the development branch of EDIorg.

daijiang commented 6 months ago

The code has been updated in other R scripts. It is just this specific one that was not updated; and this file was not used in the neonDivData project I think.