EDMdesigner / editor-issues

This is an issue tracking repository for reporting bugs, improvements and feature requests of our email editor.
5 stars 1 forks source link

Possible to modify the ckeditor config when initiating edm? #106

Open samtlewis opened 6 years ago

samtlewis commented 6 years ago

Is it possible for us to control the ckeditor configuration when initiating the EDM interface? I see when the iframe is initiated your side calls a file called EDMdesignerConfigs.js which contains references to the ckEditorConfig object for various elements. It would be awesome if we could override that config when we initiate the editor.

For instance, I see you have the spellcheck and specialchar plugins in your ckeditor build but they are not activated for any of the toolbars. If we could choose what tools are shown either based on your ckedior.js build or even a custom ckeditor build we host that would give us a lot of customization options.

Spell check and the Special Characters plugins are 2 that we have requests for now. Additionally I would like to disable the Anchor plugin in the toolbar since those are not universally supported across all browsers/clients.

Thanks,

Sam

smiska commented 6 years ago

Hi Sam, Thanks for the suggestion. I'll discuss with the DEV team how it may be implemented and I'll get back to you soon.

smiska commented 6 years ago

Hi, Currently we can't provide an option for custom configurations for ckeditor. We can add additional plugins if you find it necessary.

For what sort of toolbars would you need the spellcheck? Please help me understand your use case.

The anchor plugin is used by other partners, therefore we can't disable it.

samtlewis commented 6 years ago

Smiska, We would love to have the spell check available whenever editing any text elements be those Text, Headline, or Buttons ideally but definitely the first two. One other requirement would be that the correct language is used for the spell check based on the activated language.

The other plugin that would be quite useful is the special chars plugin for all Text/Headline elements.

We’d like the ability for our uses to be able to spell check each element (ideally spellchecking the entire email document but I don’t think that is feasible or even advisable with the way the editor is setup now). So at the least users should be able to run spell check on each text/headline element and identify mis-spelled words and be provided suggested corrections. Also, we would like to be able to provide the special chars plugin for users to use a visual guide to select accented characters, etc. from a point and click interface to include in their text/headline that they are editing.

Sam

smiska commented 6 years ago

Hi Sam, I'll look into the requirements to push an update based on your request and I'll get back to you.

smiska commented 6 years ago

Hi Sam,

We started to work on these custom plugins, but we ran into the requirement of adding a new WYSIWYG editor version and with that the requirement of updating our server engine (NodeJS) to a newer version, which caused a multitude of unit tests to fail in the API. I'll update you, when we could solve these out. ​Our apologies for the inconveniences.