EDMdesigner / editor-issues

This is an issue tracking repository for reporting bugs, improvements and feature requests of our email editor.
5 stars 1 forks source link

html source code error in multi-column #109

Open confettidc opened 6 years ago

confettidc commented 6 years ago

Dear Support,

Just found that if create the edm layout with multi-column with left text + right image.

01. Sometimes the left text with html source code error, the left text cannot display after the eDM sent out.

For example: screen shot 2018-05-08 at 10 24 53 am

02. After checked the source code, when create the eDM format like that. Sometime the system will generate the error codes like this:

The "div" merged with "style", it made the eDM cannot display the left text after sent out. Please help to solve the problem. Thanks. Jeff
confettidc commented 6 years ago

Dear Support,

For more information:

The left text + right image is the not "TEXT + IMAGE" element.

I added the multi-column element, then add "Text" element at left column and "Image" element at right column.

Thanks.

Jeff

smiska commented 6 years ago

Hi Jeff, Thanks for the detailed bug report. The reason is that we needed to change line-breaks (from "\r\n" to "\n") for the HTML and in some systems it seems that this Unix-like newline is not respected. We're already working on a fix to avoid problems with this.

confettidc commented 6 years ago

Dear Support,

Thanks for you help!

Just found more source code has same issue.

I found the similar error on:

<spanstyle ....... <pstyle ......

Hope this information can help you.

Thanks.

Jeff

smiska commented 6 years ago

Hi, we had a similar issue recently, and it there the underlying issue seems to be that the HTML generated by us is processed and linebreaks are removed by the partner's system. Could you check if you don't modify the HTML similarly?

ademirdiniz commented 6 years ago

Hi.

We have the same issue.

<spanstyle ....... <pstyle ......

What do we need to do to solve it?

smiska commented 6 years ago

@ademirdiniz As you gave us a temporary account I could take a look and it seems that for the preview (and eventually the test email and email campaing sending as well) you process the HTML, remove all the linebreaks and make the whole email HTML a single one line string. This way you remove those linebreaks, which we insert especially for long lines in the HTML, after the opening tag. I don't know the reason behind this implementation, but this seems to be the cause behind this issue.

ademirdiniz commented 6 years ago

Hi, @smiska. Thanks.

We have changed our tool to works with this EDM update.

Now is working again.

Is possible to receive an email when you publish the releases?

Thanks

smiska commented 6 years ago

Hi @ademirdiniz , I'm glad that you could solve it. @confettidc , could you check how you handle HTML on your side, and if it's not processed in a similar way?

Some form of release notification sounds well. We'll look into how this could be implemented, thanks for the suggestion.

confettidc commented 6 years ago

HI @smiska, any updates of the issue?

My customers reported this issue again.

Please help to solve it or provide some workaround.

Thanks!

smiska commented 6 years ago

Hi @confettidc , we identified that the issues by the recent update may have it's root cause with how you handle our HTML code. Could you look into it please?

Or you could set up a test account for us and we inspect what may go wrong. If you choose this option please email login credentials to the test account to support@edmdesigner.com Thanks.

confettidc commented 6 years ago

After we replace below, the issue is fixed:

<pstyle => <p style <spanstyle => <span style <divstyle => <div style <strongstyle => <strong style <ahref => <a href

Thanks for help.

smiska commented 6 years ago

Thanks for the update. I'm glad that you could solve it.

confettidc commented 6 years ago

Dear Support,

Just found new error source codes, these error occur at bullet point function:

<spanlang <spanclass <tdstyle

smiska commented 6 years ago

Can you provide projectId where this occurs? Is the rest of the template showing up correctly? Do you have reproduction steps, or doest it occur for each and every list? Any further information is greatly helpful. Thanks.

confettidc commented 6 years ago

Dear Support,

One more error source code ofund: <h1style

You may reference project id 5b0cb114743e7a26009711d2 for reference, thanks.

smiska commented 6 years ago

Apologies for the late reply.

I checked the generated HTML from this project (with multiple generation), and I could'nt find <h1style. In your implementation, probably a line-break is not respected, I highlight the one that is most likely removed when you process our HTML.

generate