search

EDMdesigner / editor-issues

This is an issue tracking repository for reporting bugs, improvements and feature requests of our email editor.
5 stars 1 forks source link

Background-image CSS property issue for Defaults and Content Tab #114

Open serokicki opened 5 years ago

serokicki commented 5 years ago

Dear Team,

I have an issue with background-image functionality in EDM editor. Everything started with "Defaults" tab in editor, we found out that using filenames or uri with "()" in filename breaks "preview" of images in editor. This happens because of "not escaping" a uri for a css background-property. Fix was fairly easy - to escape a uri. Let's say we have a file called: test (1).jpg - this would generate a link like that: "http://....../Image/136779?path=test%20(1).jpg" and it won't work because of brackets in it, so to fix this issue i've applied apostrophes to the link: "'http://....../Image/136779?path=test%20(1).jpg'" it seems that this issue appears in this line of code: image

But my fix did introduce another issue, where second tab (Content) stopped working because of those apostrophes. Could you please look into this issue?

Thank you in advance.

gyulanemeth commented 5 years ago

Hello, the problem is that in many cases it's not advised to escape those urls. Can you maybe rename the images?

agnieszkakowalska commented 5 years ago

Hi Gyula, if these were our images - sure. But we can't control what names client has for their images.