search

EDMdesigner / editor-issues

This is an issue tracking repository for reporting bugs, improvements and feature requests of our email editor.
5 stars 1 forks source link

Edit bullet point problem #36

Closed confettidc closed 8 years ago

confettidc commented 8 years ago

Dear Support,

We found that when using bullet points in text block, the points are not alighted properly: 2016-05-17_14-33-13

But the format is correct after export HTML: 2016-05-17_14-34-19

Although the final result is correct, we still hope that the bullet point effect will be consistent with exported html.

Please advise if this can be fixed.

Thanks.

gyulanemeth commented 8 years ago

Hello,

this is happening because we change the bullet-points to tables when we generate the html, but while editing it's a valid look, because there are no tables behind. I think it's actually not fixable.

leggomuhgreggo commented 8 years ago

Out of curiosity, why to you change them to tables? Do lists get some undesirable client render?

On Wed, Jun 8, 2016 at 10:54 AM, Gyula Németh notifications@github.com wrote:

Hello,

this is happening because we change the bullet-points to tables when we generate the html, but while editing it's a valid look, because there are no tables behind. I think it's actually not fixable.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/EDMdesigner/editor-issues/issues/36#issuecomment-224615311, or mute the thread https://github.com/notifications/unsubscribe/ACHHBLXTBvcFsWBRfkRt_ga6UGa0WYywks5qJtexgaJpZM4If-YI .

gyulanemeth commented 8 years ago

Yes, simple lists are not stable enough. This way we can ensure that bulletpoint lists will look nice on all clients.

leggomuhgreggo commented 8 years ago

Understandable. I appreciate the answer. Looks like in the editor the default list styles are being overridden and dropping the indentation by setting ul,ol { padding:0}.

Assuming the default indentation is problematic for some reasons and it's necessary to override it in the editor styles with the counter for the ol and the list-style: disc inside for the ul, you could add this to recreate that indentation:

ol,ul{
  padding-left: 40px;
  list-style:none; //for both now

  li:before{
    position: absolute;
    left: 0;
    margin-left: -18px;
  } 
}

ul li:before{
  content:'• '
}

codepen