EDMdesigner / editor-issues

This is an issue tracking repository for reporting bugs, improvements and feature requests of our email editor.
5 stars 1 forks source link

54834S: Issue with email templates not sending in the correct font #58

Closed GVSupport closed 7 years ago

GVSupport commented 8 years ago

We're having an issue with one of our client's email templates. The emails that are being sent have the incorrect font for some of the elements. I've had a look at the source code for the email, and the issue is that the font-family is being set to %26quot; on some of the HTML elements.

I suspect that there may be an issue with the HTML generation in the designer code. Is this something you can take a look at?

The name of the template is Concur Fusion 1.

rolficak commented 8 years ago

@GVSupport Can you please send us the project id, JSON and the exported HTML code? Than @stubendek will look into this.

Please next time when you open such ticket, also include the above information, since without that we cannot investigate.

GVSupport commented 8 years ago

The project Id is 57eb91f5b77c4cba28eceb65. I will email the HTML source.

stubendek commented 8 years ago

To reproduce and solve the issue we need rather the mail JSON.

stubendek commented 8 years ago

I could almost reproduce the issue, got: font-family: "trebuchet ms" as an inline style attribute item of a paragraph. Searched the source JSON and found the identical paragraph with the incorrect styling, so the resulted paragraph code is from the ckeditor or other html editor tool. a) I think the editor should format quoted font types with single quots BUT b) I will also get the generator to be prepared to handle quots in an appropriate way.

GVSupport commented 8 years ago

Thanks for looking into the issue. Are you able to give an estimate as to when a release with these changes included will be available?

stubendek commented 8 years ago

The changes will be included tomorrow. Thank you for your patience.

GVSupport commented 7 years ago

I've updated the client's API to r2016114 using the EDM dashboard but I'm still seeing issues with the font rendering. Looking at the HTML source of the email preview, it looks like the inline styles still aren't right, e.g. one paragraph has <span style="font-family: trebuchet ms font-size;">. Are the changes definitely included in this release?

ughoo commented 7 years ago

Hi GVsupport, please help us understand, where you checked the preview? Did you use the app, or the dashboard? Also please send the latest version of json and html, because we are not able to reproduce this issue.

GVSupport commented 7 years ago

Sorry, I didn't make myself clear. The preview in the iframe looks OK, but when I send the template as an email via our system, the fonts are still messed up. I will email you the JSON, but I've had a quick look and don't see any obvious issues. I suspect that we probably need to make a change to the way we process the data on our end to account for your changes.

ughoo commented 7 years ago

Hi,

thanks for the information. Let me know, if the bug comes up.

Regards, Greg ᐧ

On Thu, Jan 5, 2017 at 2:53 PM, GVSupport notifications@github.com wrote:

Sorry, I didn't make myself clear. The preview in the iframe looks OK, but when I send the template as an email via our system, the fonts are still messed up. I will email you the JSON, but I've had a quick look and don't see any obvious issues. I suspect that we probably need to make a change to the way we process the data on our end to account for your changes.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/EDMdesigner/editor-issues/issues/58#issuecomment-270648767, or mute the thread https://github.com/notifications/unsubscribe-auth/AD_4Ho7rkY7oz2y_jsc3QbxK_4I0Ib5Cks5rPPXrgaJpZM4KPwwg .

-- Gergely Mecs

Chief Frontend Developer @ EDMdesigner.com

GVSupport commented 7 years ago

I've sent you through the html. It looks like the problem's here rather than in the JSON,

gyulanemeth commented 7 years ago

The mentioned files:

htmlSource.txt

template.json.txt

smiska commented 7 years ago

Hi GVSupport,

The generator was updated so if you try to re-create your project you should see the correct font rendering. Please check if that is the case, and if I can close the ticket!

Thanks!