EDMdesigner / editor-issues

This is an issue tracking repository for reporting bugs, improvements and feature requests of our email editor.
5 stars 1 forks source link

Hide on Mobile - increase resolution #66

Open agnieszkakowalska opened 7 years ago

agnieszkakowalska commented 7 years ago

Guys,

The button "Hide on Mobile" is working for devices with resolution under 600x400px. Since most of the phones already have bigger screens then maybe this condition should be changed?

Please also let me know if Gmail "hack" is already released? You wrote that "we are working on a hack to fix Gmail app as well (it's still in research/dev phase, so there's no release that for this yet)" https://github.com/EDMdesigner/email-html-generator-issues/issues/6

Thank you :)

agnieszkakowalska commented 7 years ago

Hi guys, can you please answer my questions? :)

rolficak commented 7 years ago

The hide on mobile is not supported on older Gmail Apps, only on updated versions. We cannot do anything about it.

The Gmail fix was already released 2 months ago, so in new Gmail app versions the hide on mobile works. http://edmdesigner.com/compatibility

The true resolution of phones is still 320 px with a retina approach. The higher the listed resolution is, the more pixels they display in that small screen. ᐧ

Roland Pokornyik CEO, Co-founder @ EDMdesigner.com

+36-70-608-4433

Schedule http://www.meetme.so/Roland-EDMdesigner a Skype chat with me!

On Tue, Jan 10, 2017 at 10:54 AM, agnieszkakowalska < notifications@github.com> wrote:

Hi guys, can you please answer my questions? :)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/EDMdesigner/editor-issues/issues/66#issuecomment-271532653, or mute the thread https://github.com/notifications/unsubscribe-auth/AF2xnVB9i9OSlJ4vVlwE-ZSI7PYs2YeDks5rQ1U_gaJpZM4LRjjU .

agnieszkakowalska commented 7 years ago

Hi Roland, I was not aware that there is a new version of editor. Is there any changelog? Does the gmail hack require updating the editor or not?

agnieszkakowalska commented 7 years ago

Can you also let me know what are the exact conditions on which editor decides if message is opening on a desktop or on a mobile device? Because it's not fully clear for my customer. He tested it and saw that the button doesn't work anywhere except new gmail application.

rolficak commented 7 years ago

Hi Agnieszka,

The generator is updated automatically. That's part of our service. You don't need to change editor version to make use of the latest generator release.

Template reorders to one column is the device width is below 600px. The same width applies for the hide on mobile to work.

Roland Pokornyik CEO, Co-founder @ EDMdesigner.com

+36-70-608-4433

Schedule http://www.meetme.so/Roland-EDMdesigner a Skype chat with me!

On Wed, Jan 11, 2017 at 12:41 PM, agnieszkakowalska < notifications@github.com> wrote:

Can you also let me know what are the exact conditions on which editor decides if message is opening on a desktop or on a mobile device? Because it's not fully clear for my customer. He tested it and saw that the button doesn't work anywhere except new gmail application.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/EDMdesigner/editor-issues/issues/66#issuecomment-271847798, or mute the thread https://github.com/notifications/unsubscribe-auth/AF2xnSVEDygKE0S05A_gKXfimykXX3Hgks5rRL_tgaJpZM4LRjjU .

agnieszkakowalska commented 7 years ago

Hi Roland, Thank you for your answer. Can I please ask you to answer client's question below?

"We have Samsung Galaxy GT-I9515 with screen resolution 1920×1080, 441 ppi. We opened message in the last version of Gmail application. When we hold the phone in vertical position it shows us mobile version. When we hold the phone in horizontal position it shows us desktop version. Why?"

obraz

obraz

ughoo commented 7 years ago

Hi Agneszka,

"1920×1080, 441 ppi" is the hardware resolution of the device, but based on the software and unique vendor drivers all devices have software based resolutions. Meta viewport initial-scale: 1.0 triggers an initial state on mobile;

As you can see the portrait screenshot, that is below 600px, so it shows mobile version, while the landspace will be higher than the 600px, so its shows desktop version. You can check these values from the original screenshots, usually they are captured on actual resolution.

I hope that helps

agnieszkakowalska commented 7 years ago

Is there a chance to know software resolution of some definite application for us? Or we never know it until we test it?

ughoo commented 7 years ago

There is no global stats for that, and some vendors make unique customizations (all Samsung Note) which can change the initial sizes....so that make it much more difficult to know without testing.

Some sites like this: http://viewportsizes.com/ try to collect the native resolution values, but not the smallest initial ones..