EDRN / P5

EDRN Production Program for the Public/Private Portal (P5)
https://edrn.nci.nih.gov/
Other
2 stars 0 forks source link

On-line reference set application #225

Closed hoodriverheather closed 1 year ago

hoodriverheather commented 1 year ago

🤔 Tell Us About the Feature

Develop on-line application pages for EDRN specimen reference sets - https://edrn-dev.jpl.nasa.gov/portal/renaissance/data-and-resources/specimen-reference-sets/

🎇 What Solution You'd Like

EDRN_General_Reference_Set_Application_Form_04_02_2015 (2).docx

Additional Requirements

The following requirements arose during the Bio-informatics Systems Planning Meeting 2023-03-09:

EDRN Standard Specimen Reference Set Guidelines-Blinding Policy.pdf

〽️ Alternative Ideas

Do not include a way to review and approve via the on-line forms for this version?

nutjob4life commented 1 year ago

@hoodriverheather's notes:

From my notes from our call in December (please let me know if I got any of this incorrect):

nutjob4life commented 1 year ago

@hoodriverheather I have a prototype here:

https://edrn-dev.jpl.nasa.gov/portal/renaissance/data-and-resources/specimen-reference-sets/specimen-set-request-form/

Right now it just packages up all the answers and email them, and for now it only emails to you and me.

hoodriverheather commented 1 year ago

@nutjob4life Looking good. I have a few edits that I made on screenshots. See below. Also, is there a way to add section headers? It might be nice or maybe too much??

Screenshot 2023-03-07 at 2 30 13 PM Screenshot 2023-03-07 at 2 34 06 PM Screenshot 2023-03-07 at 2 46 38 PM
hoodriverheather commented 1 year ago

@nutjob4life What Happens Next message to the suggested edit in the screenshot? I just don't want the submitter to think the DMCC is reviewing their application, so i took text from the form.

Screenshot 2023-03-07 at 3 01 53 PM

I know Jackie will be updating this form, so if any of these updates are time consuming we could just hold off and ask her for edits first.

nutjob4life commented 1 year ago

@hoodriverheather take a look at https://edrn-dev.jpl.nasa.gov/portal/renaissance/data-and-resources/specimen-reference-sets/specimen-set-request-form/ for the latest updates based on your feedback:

Let me know if there are any other changes needed before the meeting on 3-9.

FYI, this seems to be "challenge logarithmic curve" when doing forms in Wagtail (and its underlying application server, Django):

  1. 👶 Trivial: design a form with basic controls that sends an email, through-the-web, no code needed
  2. 💪 Easy: a form consisting of a series of linear fields of beyond-the-basics data types—may even have dynamic data choices—that sends email
  3. 😅 Intermediate: a form consisting of linear fields that post-processes the data before sending email or does something other than email (this where is the metadata collection form is because it has to generate the .cfg file format)
  4. 🥵 Difficult: a form that requires special page layout (this is where the reference set application form is now)
  5. 🛑 Impossible: inter-dependent field logic: where choices made in one field affect what can be entered into others

Of course, I'm still a newbie when it comes to these technologies. Others out there may have a much better handle on these.

Moving the "Scientific Proposal" preamble text to the middle of the form and adding section headers is what turned the reference set application from level 3 to level 4.

hoodriverheather commented 1 year ago

@nutjob4life this is really looking great! Suggested update below to remove Proposal header and sentence below (see screenshot).

Screenshot 2023-03-08 at 1 22 34 PM

I think the section on funding in the word form is just asking for specific items to be checked and data entered. No prose entry. I could be wrong, but when I try to fill that form out in word the "How will testing the reference set(s) be funded?" seems to just be a label. Would you mind making the updates suggested above for the funding section?

The same seems to be the case with the IRB section. "Do you have IRB approval to work with the requested samples?" is a label. I think it's OK to leave that for now.

Thanks for the explanation of the levels for the form development - very helpful!

Thanks!

nutjob4life commented 1 year ago

@hoodriverheather wrote:

Would you mind making the updates suggested above for the funding section?

I would if I could. But like I said, I can't do the funding the way you want above in your screen shot with red text. There's no way to link one set of controls to other sets fields.

"A radiobutton to indicate funding that enables/disables other boxes are not possible at this time." —Me, above

That's why I left a large open box. I know they're not supposed to enter a bunch of prose. But that's the trade-off 🫤 That's why the text below that box says:

If there is a current NIH-funded grant, enter the grant №, annual direct costs, and funding period. If there is other sponsorship, provide a statement of committment from the sponsoring agency, company, or foundation. If there is some other funding, please specify.

There's no way in Wagtail forms to see if a user checks a box "Current NIH-funded grant" to then enable fields for "Grant number", "Annual Direct Costs", and "Funding Period"—and to validate that "If current NIH-funded grant is checked, ensure values or filled in for these other fields. Or if the user checks "Other" to then turn on a "Specify" box. Etc.

Besides, aren't you supposed to print out the Word forms and fill them in with a pen? It wouldn't matter what parts of the Word document are editable and which aren't, right 🤔

nutjob4life commented 1 year ago

@hoodriverheather hang on, I thought of another possible trade-off. There'll be zero validation but it could give separate boxes.

Hang tight.

nutjob4life commented 1 year ago

@hoodriverheather okay try https://edrn-dev.jpl.nasa.gov/portal/renaissance/data-and-resources/specimen-reference-sets/specimen-set-request-form/ now.

hoodriverheather commented 1 year ago

@nutjob4life Perfecto!! I was going to say, they don't have to be linked, but at least they would have a spot to enter something :)

nutjob4life commented 1 year ago

Whew!! 😅

nutjob4life commented 1 year ago

The following ref set pages now use the online form:

Ignore the "(PDF)" that still appears on these pages; those will disappear after tomorrow's (3-11) production database refresh.

I did not link the following ref set pages to the online form because they each used a custom Word doc different from the standard EDRN ref set app form:

hoodriverheather commented 1 year ago

@nutjob4life This is looking great. I think the Specimen Type field also needs to allow select all that apply. I'm not sure if minimum volume needs to change. UGH! I wonder if the volume needs to refer to the specimen type.

nutjob4life commented 1 year ago

@hoodriverheather okay, Specimen Type is now checkboxes and min volume is now a text area. Check it out.

nutjob4life commented 1 year ago

@hoodriverheather to QC this, visit the Specimen Reference Sets page and try one of the links such as "Colon cancer".

hoodriverheather commented 1 year ago

@nutjob4life Looks great!!