EDRN / labcas-ui

User Interface for the Laboratory Catalog and Archive Service (LabCAS)
Apache License 2.0
0 stars 0 forks source link

Prompted to add username and password for public data download #151

Open askarlupka opened 1 year ago

askarlupka commented 1 year ago

🐛 Describe the Bug

When downloading publicly accessible datafiles, I am prompted in the data use agreement to include my username and password. My understanding is that it's a public collection, so login isn't required.

📜 How To Reproduce

  1. Go to `https://edrn-labcas.jpl.nasa.gov/labcas-ui/c/index.html?collection_id=Analysis_of_pancreatic_cancer_biomarkers_in_PLCO_set'
  2. Click on 'Download All` image

Comparatively, if the red download button in the action column is used instead, the data use agreement does not show up, and download is immediate.

❗️ Mention if the bug appears when you're logged in, all the time, etc. Not logged in

🔎 Expected Behavior

Should have data use agreement for all cases, but since it's public no requirement for log-in information

yuliujpl commented 1 year ago

@askarlupka good find! Yes we wanted to include the form for all downloads, including public in order to track usage agreements for all data. However, if you entered your username/password once, it shouldn't prompt again. It sounds like the red download button is not triggering a user form when you're logged out when it should have prompted. I will fix this!

askarlupka commented 1 year ago

@yuliujpl I'm also not getting the prompt when I am on the file's metadata site. I'm not logged in, and when I select the download button I receive no usage agreement pop up.

image