search

EDRN / labcas-ui

User Interface for the Laboratory Catalog and Archive Service (LabCAS)
Apache License 2.0
0 stars 0 forks source link

UI should return you to original page that prompted a login #212

Open nutjob4life opened 3 weeks ago

nutjob4life commented 3 weeks ago

🐛 Describe the Bug

When someone gives you a link to a protected page in the LabCAS UI, you are prompted to log in, which is great. However, after logging in, you're not returned to that page; instead you land on the Collection Search Results.

📜 How To Reproduce

  1. First, make sure you're not logged into EDRN LabCAS
  2. Visit this link
  3. You're prompted to log in; log in as a user who should have access, such as a Super User
  4. After logging in, you land on this page

🔎 Expected Behavior

You should instead land on this page.

🕵️‍♀️ Extra Details

If this is previously reported, go ahead and close this issue, leaving a comment with the issue number. Thank you! 🙏

yuliujpl commented 3 weeks ago

Hi Sean, we removed this return to page capability because when a page has weird characters ingested (symbols that urlencode and other strange characters) or a mix of other issues, the user gets redirected to login and out over and over again, never able to effectively use labcas!

From: Sean Kelly @.> Sent: Wednesday, July 3, 2024 6:36 AM To: EDRN/labcas-ui @.> Cc: Liu, David (US 3902-Affiliate) @.>; Assign @.> Subject: [EXTERNAL] [EDRN/labcas-ui] UI should return you to original page that prompted a login (Issue #212)

🐛 Describe the Bug

When someone gives you a link to a protected page in the LabCAS UI, you are prompted to log in, which is great. However, after logging in, you're not returned to that page; instead you land on the Collection Search Results.

📜 How To Reproduce

  1. First, make sure you're not logged into EDRN LabCAShttps://edrn-labcas.jpl.nasa.gov/
  2. Visit this linkhttps://edrn-labcas.jpl.nasa.gov/labcas-ui/f/index.html?file_id=Lung_Team_Project_2/Images_Site_UB5yhu2StyPSLQ/5079467/1.2.826.0.1.3680043.2.135.737433.64551676.7.1646135260.15.87_0002_000001_16461354490e8b.dcm
  3. You're prompted to log in; log in as a user who should have access, such as a Super User
  4. After logging in, you land on this pagehttps://edrn-labcas.jpl.nasa.gov/labcas-ui/s/index.html?search=*

🔎 Expected Behavior

You should instead land on this pagehttps://edrn-labcas.jpl.nasa.gov/labcas-ui/f/index.html?file_id=Lung_Team_Project_2/Images_Site_UB5yhu2StyPSLQ/5079467/1.2.826.0.1.3680043.2.135.737433.64551676.7.1646135260.15.87_0002_000001_16461354490e8b.dcm.

🕵️‍♀️ Extra Details

If this is previously reported, go ahead and close this issue, leaving a comment with the issue number. Thank you! 🙏

— Reply to this email directly, view it on GitHubhttps://urldefense.us/v3/__https://github.com/EDRN/labcas-ui/issues/212__;!!PvBDto6Hs4WbVuu7!IllKf5i2gCGWeyvNNs4vGHJwMkKnEhnpsBvvAjrON2iPl5NFB8w3ExwhK3bRjlIAs7kDpS82mKSBc8nGld0a2CGwwZaDjA$, or unsubscribehttps://urldefense.us/v3/__https://github.com/notifications/unsubscribe-auth/ADXFXXGCM6PNJFX2EA2JFEDZKP47TAVCNFSM6AAAAABKJTNGLOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM4DQNRWGA3TKMA__;!!PvBDto6Hs4WbVuu7!IllKf5i2gCGWeyvNNs4vGHJwMkKnEhnpsBvvAjrON2iPl5NFB8w3ExwhK3bRjlIAs7kDpS82mKSBc8nGld0a2CHHLXCN3w$. You are receiving this because you were assigned.Message ID: @.***>

nutjob4life commented 3 weeks ago

Thankd @yuliujpl—but this doesn't sound intractable. Literally thousands of websites support this nicety for end-users. Let's leave this open until a solution presents itself 😌

yuliujpl commented 3 weeks ago

I don't disagree! One idea is can we perhaps have ingestion to clean at least the ids before they load into solr? Seems strange that we have ids that have ()#"' symbols in them. Makes it quite hard not just for URL redirection but also image viewing in 3rd party tools!

From: Sean Kelly @.> Sent: Wednesday, July 3, 2024 12:20 PM To: EDRN/labcas-ui @.> Cc: Liu, David (US 3902-Affiliate) @.>; Mention @.> Subject: [EXTERNAL] Re: [EDRN/labcas-ui] UI should return you to original page that prompted a login (Issue #212)

Thankd @yuliujplhttps://urldefense.us/v3/__https://github.com/yuliujpl__;!!PvBDto6Hs4WbVuu7!I2I-Vj6hvelupcj2xBlG2w2vf8LrJ-7ts47vFwtkbJ4M1mYCmJgmWOkxVGn8qSnHMmbb8YQ20i5OoDnfuejgSwXoBMZWgw$—but this doesn't sound intractable. Literally thousands of websites support this nicety for end-users. Let's leave this open until a solution presents itself 😌

— Reply to this email directly, view it on GitHubhttps://urldefense.us/v3/__https://github.com/EDRN/labcas-ui/issues/212*issuecomment-2207025909__;Iw!!PvBDto6Hs4WbVuu7!I2I-Vj6hvelupcj2xBlG2w2vf8LrJ-7ts47vFwtkbJ4M1mYCmJgmWOkxVGn8qSnHMmbb8YQ20i5OoDnfuejgSwVBCLRAIA$, or unsubscribehttps://urldefense.us/v3/__https://github.com/notifications/unsubscribe-auth/ADXFXXBU2Q26UGL7IAIPF4TZKRFJDAVCNFSM6AAAAABKJTNGLOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBXGAZDKOJQHE__;!!PvBDto6Hs4WbVuu7!I2I-Vj6hvelupcj2xBlG2w2vf8LrJ-7ts47vFwtkbJ4M1mYCmJgmWOkxVGn8qSnHMmbb8YQ20i5OoDnfuejgSwVnz2o3FA$. You are receiving this because you were mentioned.Message ID: @.***>

nutjob4life commented 1 week ago

Let's bring up ID normalization on our next call; in general this sounds like a good idea

In the mean time, I'm curious why URL-escaping isn't used in the UI