EDePasquale / DoubletDecon

A tool for removing doublets from single-cell RNA-seq data
69 stars 19 forks source link

Minor issue with latest update for Seurat 4 #43

Closed Dazcam closed 3 years ago

Dazcam commented 3 years ago

Hi Erica,

There is a typo in lines 27-28 of the most recent update to the Improved_Seurat_Pre_Process() function.

In Seurat 4 scaled data is located here seuratObject@assays[["RNA"]]@scale.data, whereas the code below is directed to seuratObject@assays[["RNA"]]@scaled.data.

    #extract expression file
    if(data_type=="counts"){
      expression=as.data.frame(seuratObject@assays[["RNA"]]@counts)
    }else if(data_type=="data"){
      expression=as.data.frame(seuratObject@assays[["RNA"]]@data)
    }else if(data_type=="scaled.data"){
      expression=as.data.frame(seuratObject@assays[["RNA"]]@scaled.data)
    }

Otherwise the new updates work well.

Best,

Darren

EDePasquale commented 3 years ago

Oops! Fixed now. Thanks, Darren!