search

EDmodel / ED2

Ecosystem Demography Model
78 stars 112 forks source link

Radiative schemes for ED2 #133

Open Viskari opened 8 years ago

Viskari commented 8 years ago

Just checking as ED2 no longer allows using the old two-stream radiative model (ICANRAD = 0) in ED2IN even though it is still listed as an option in radiate_transfer.f90.

Why was it removed as a run option?

rgknox commented 8 years ago

If I recall correctly, like you say, ICANRAD=0 should be removed as an option if a user selects 0 it should generate an error. This should be on the to-do list.

Viskari commented 8 years ago

It generates the error, but I am confused as that option the associated sub-program are still included in radate_driver.f90. Additionally the cohort approach choice in ED2IN then becomes obsolete as it currently only is allowed with ICANRAD=0.

On Tue, Nov 3, 2015 at 2:14 PM, Ryan Knox notifications@github.com wrote:

If I recall correctly, like you say, ICANRAD=0 should be removed as an option if a user selects 0 it should generate an error. This should be on the to-do list.

— Reply to this email directly or view it on GitHub https://github.com/EDmodel/ED2/issues/133#issuecomment-153458281.

serbinsh commented 8 years ago

@Viskari I think you need to explain the conflicting choices within the ED2IN and the issue with the finite radius approach. You second comment is a bit confusing.