search

EDmodel / ED2

Ecosystem Demography Model
78 stars 112 forks source link

Typo in the events.f90 file #353

Open femeunier opened 2 years ago

femeunier commented 2 years ago

There is a small typo when the code is reading the event file in the case of harvest, it shout assign the value to rval(4) instead of rval(3), see and previous lines

https://github.com/EDmodel/ED2/blob/911e266cd439eeb633de1e5257c08cb95bfc4c7c/ED/src/dynamics/events.f90#L121

I open an issue for the record, I will prepare a pull request soon.

pmoorcroft commented 2 years ago

@femeunier Marcos, Rob and I found a similar issue at lines 138-150 (fertilize lines).

mpaiao commented 2 years ago

@femeunier Are you still planning on submitting the pull request? Because you spotted the problem first, it would be better if you created the PR, but we can make one too if you are not planning to submit it.

femeunier commented 2 years ago

If you want to proceed rapidly, please go ahead!! I'll leave tomorrow for a conference and will have no time to submit a pull request before a week or so ...