improved pattern null check

EE / angular-ui-tree-filter

A module providing an AngularJS filter which can be used with angular-ui-tree to match tree nodes.

ee.github.io/angular-ui-tree-filter

MIT License

40 stars 21 forks source link

improved pattern null check #11

Open michaelmalone opened 8 years ago

michaelmalone commented 8 years ago

modified short circuit on 'pattern' parameter to use a truthy check rather than explicitly checking against undefined. This will stop the filter from processing when the pattern is null or empty in addition to undefined.

jrencz commented 8 years ago

@michaelmalone Thank you for your contribution!

Would you mind writing a test to cover this case as well?

michaelmalone commented 8 years ago

Sure, will add the test soon.