search

EEGInt / awstasks

Automatically exported from code.google.com/p/awstasks
Apache License 2.0
0 stars 0 forks source link

S3Upload broken on Windows #7

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Run an S3Upload ant task on Windows

What is the expected output? What do you see instead?

Files are uploaded using relative path. Instead they are uploaded using the 
canonical path.

What version of the product are you using? On what operating system?

Newest version of the development branch on Windows.

Please provide any additional information below.

Easy to fix. You do a string replacement for "\\\\" on the filepath but not on 
the root. This causes the logic where you check to see if they match to fail on 
Windows (but not on *nix). You can easily fix this by replacing line 257 of 
S3Upload.java w:

  String  rootx = normalize(root.getCanonicalPath()).replaceAll("\\\\", "/");

I've already done this locally and verified that it works.

Original issue reported on code.google.com by dro...@gmail.com on 19 Aug 2011 at 10:38