search

EEHarbor / Manifest

ExpressionEngine configuration through environment variables
16 stars 2 forks source link

Two levels up #1

Open robsonsobral opened 9 years ago

robsonsobral commented 9 years ago

Hi!

I'm sorry for being the first to bother you.

Why not to put the directory .env two levels up, instead of inside system\expressionengine? It could be one less thing to bother us on update.

Thanks for the attention and for the Manifest.

bryannielsen commented 9 years ago

Hi @robsonsobral!

Thanks for taking a look at Manifest and giving your feedback, it's always appreciated :-)

You're the second person to mention this and I think it makes complete sense. So we're going to make the path configurable. The reason for using system/expressionengine is because the global APPPATH variable is one of the few reliable system path var's available so early in the process.

We also didn't want to assume that everyone is using the default system/expressionengine value as their APPPATH and load the .env from two levels above that. But it seems the best approach will be to use APPPATH as the default and allow each install to decide where the .env file should live.

Thanks again for your interest!

robsonsobral commented 9 years ago

Thanks for your attention!

If every thing we don't need to update on eecms was a sibling directory or file of the BASEPATH, the life will be simpler.

Thanks for think about it. Thank you!