EESSI / eessi-bot-software-layer

Bot to help with requests to add software installations to the EESSI software layer
GNU General Public License v2.0
0 stars 16 forks source link

Improve display of build targets #262

Closed trz42 closed 2 months ago

trz42 commented 2 months ago

Shortens the list of "build targets" (architectures and repository ids). This is shown when a PR is opened or for the command bot: show_config. Tested in https://github.com/trz42/software-layer/pull/72

Example:

Old display

Instance dev-PR254 is configured to build:

New display

Instance dev-PR254 is configured to build for:

trz42 commented 2 months ago

Most instances will be running on sites where the same architectures are relevant for all repos. This doesn't necessarily have to be the case (e.g. map of zen2 and zen3 for repo A and only zen2 in repo B) and in those cases that distinction is lost with the new reporting (unless I'm missing something). This new conciseness is much better than the previous bullet list, but maybe in a future iteration it might be nice to use a "drop-down on click" approach, or have something like

  • zen3 - repoA, repoB
  • zen2 - repoB

That's a nice idea. (Thought about that too, but then was too lazy to implement it in the first iteration.)

boegel commented 2 months ago

I agree with Pedro's feedback, why not simply do something like:

Instance dev-PR254 is configured to build:

<details>
...
</details>
trz42 commented 2 months ago

I agree with Pedro's feedback, why not simply do something like:

Instance dev-PR254 is configured to build:

<details>
...
</details>

Sure. Another option would be

Instance dev-PR254 is configured to build: (click for details) - `zen3` - `repoA`, `repoB` - `zen2` - `repoB`

Little downside is that you have to click to see it.

Anyhow everyone can make a PR for an improvement.