search

EESSI / software-layer

Software layer of the EESSI project
https://eessi.github.io/docs/software_layer
GNU General Public License v2.0
23 stars 46 forks source link

Only correct the Zen4 software subdirectory if it has not been overridden #573

Closed ocaisa closed 4 months ago

ocaisa commented 4 months ago

Forcing Zen3 over Zen4 was not respecting $EESSI_SOFTWARE_SUBDIR_OVERRIDE

eessi-bot[bot] commented 4 months ago

Instance eessi-bot-mc-aws is configured to build:

eessi-bot[bot] commented 4 months ago

Instance eessi-bot-mc-azure is configured to build:

ocaisa commented 4 months ago

Works as intended:

[ocaisa@x86-64-amd-zen4-node1 software-layer]$ source init/bash 
Found EESSI repo @ /cvmfs/software.eessi.io/versions/2023.06!
archdetect says x86_64/amd/zen4
Sticking to x86_64/amd/zen3 for now, since optimized installations for AMD Genoa (Zen4) are a work in progress, see https://gitlab.com/eessi/support/-/issues/37 for more information
...
{EESSI 2023.06} [ocaisa@x86-64-amd-zen4-node1 software-layer]$ export EESSI_SOFTWARE_SUBDIR_OVERRIDE=x86_64/amd/zen4
{EESSI 2023.06} [ocaisa@x86-64-amd-zen4-node1 software-layer]$ source init/bash 
Found EESSI repo @ /cvmfs/software.eessi.io/versions/2023.06!
archdetect says x86_64/amd/zen4
Using x86_64/amd/zen4 as software subdirectory.
...
boegel commented 4 months ago

Tests are not happy?

ocaisa commented 4 months ago

It's https://github.com/easybuilders/easybuild-easyconfigs/pull/20501 , tricky one to decide what to do about it

boegel commented 4 months ago

It's easybuilders/easybuild-easyconfigs#20501 , tricky one to decide what to do about it

Filter out PSM2 in our parse hook (at least in short term)?

ocaisa commented 4 months ago

Solution in https://github.com/EESSI/software-layer/pull/576

boegel commented 4 months ago

@ocaisa #576 merged, so this just needs a kick?

ocaisa commented 4 months ago

@boegel all the open PRs need a sync with the default branch due to the change in the EasyBuild configuration, starting on it now

ocaisa commented 4 months ago

bot: build repo:eessi.io-2023.06-software arch:x86_64/generic

eessi-bot[bot] commented 4 months ago
Updates by the bot instance eessi-bot-mc-aws (click for details) - received bot command `build repo:eessi.io-2023.06-software arch:x86_64/generic` from `ocaisa` - expanded format: `build repository:eessi.io-2023.06-software architecture:x86_64/generic` - handling command `build repository:eessi.io-2023.06-software architecture:x86_64/generic` resulted in: - submitted job `10866`, for details & status see https://github.com/EESSI/software-layer/pull/573#issuecomment-2114780308
eessi-bot[bot] commented 4 months ago
Updates by the bot instance eessi-bot-mc-azure (click for details) - received bot command `build repo:eessi.io-2023.06-software arch:x86_64/generic` from `ocaisa` - expanded format: `build repository:eessi.io-2023.06-software architecture:x86_64/generic` - handling command `build repository:eessi.io-2023.06-software architecture:x86_64/generic` resulted in: - no jobs were submitted
eessi-bot[bot] commented 4 months ago
New job on instance eessi-bot-mc-aws for architecture x86_64-generic for repository eessi.io-2023.06-software in job dir /project/def-users/SHARED/jobs/2024.05/pr_573/10866 date job status comment
May 16 10:08:16 UTC 2024 submitted job id 10866 awaits release by job manager
May 16 10:08:22 UTC 2024 released job awaits launch by Slurm scheduler
May 16 10:09:24 UTC 2024 running job 10866 is running
May 16 10:14:29 UTC 2024 finished
:grin: SUCCESS (click triangle for details)
Details
:white_check_mark: job output file slurm-10866.out
:white_check_mark: no message matching ERROR:
:white_check_mark: no message matching FAILED:
:white_check_mark: no message matching required modules missing:
:white_check_mark: found message(s) matching No missing installations
:white_check_mark: found message matching .tar.gz created!
Artefacts
eessi-2023.06-software-linux-x86_64-generic-1715854112.tar.gzsize: 0 MiB (1892 bytes)
entries: 1
modules under _2023.06/software/linux/x8664/generic/modules/all
no module files in tarball
software under _2023.06/software/linux/x8664/generic/software
no software packages in tarball
other under _2023.06/software/linux/x8664/generic
2023.06/init/eessi_environment_variables
May 16 10:14:29 UTC 2024 test result
:grin: SUCCESS (click triangle for details)
ReFrame Summary
[ PASSED ] Ran 10/10 test case(s) from 10 check(s) (0 failure(s), 0 skipped, 0 aborted)
Details
:white_check_mark: job output file slurm-10866.out
:white_check_mark: no message matching ERROR:
:white_check_mark: no message matching [\s*FAILED\s*].*Ran .* test case
May 16 10:53:07 UTC 2024 uploaded transfer of eessi-2023.06-software-linux-x86_64-generic-1715854112.tar.gz to S3 bucket succeeded
ocaisa commented 4 months ago

@boegel This is ready to go now

boegel commented 4 months ago

Sorry for overlooking the deployment part... I saw a green light by CI, so I went for it :)