search

EESSI / software-layer

Software layer of the EESSI project
https://eessi.github.io/docs/software_layer
GNU General Public License v2.0
22 stars 46 forks source link

Create_tarball might not include Lmod cache and config files correctly for GPU builds #722

Open casparvl opened 6 days ago

casparvl commented 6 days ago

I see that new files were created during the install step:

>> Creating/updating Lmod RC file...
/cvmfs/software.eessi.io/versions/2023.06/software/linux/x86_64/amd/zen2/accel/nvidia/cc80/.lmod/lmodrc.lua
ESC[32m/cvmfs/software.eessi.io/versions/2023.06/software/linux/x86_64/amd/zen2/accel/nvidia/cc80/.lmod/lmodrc.lua createdESC[0m
>> Creating/updating Lmod SitePackage.lua ...
/cvmfs/software.eessi.io/versions/2023.06/software/linux/x86_64/amd/zen2/accel/nvidia/cc80/.lmod/SitePackage.lua
ESC[32m/cvmfs/software.eessi.io/versions/2023.06/software/linux/x86_64/amd/zen2/accel/nvidia/cc80/.lmod/SitePackage.lua createdESC[0m

But the create_tarball only looks at

if [ -d ${eessi_version}/software/${os}/${cpu_arch_subdir}/.lmod ]; then
    # include Lmod cache and configuration file (lmodrc.lua),
    # skip whiteout files and backup copies of Lmod cache (spiderT.old.*)
    find ${eessi_version}/software/${os}/${cpu_arch_subdir}/.lmod -type f | egrep -v '/\.wh\.|spiderT.old' >> ${files_list}
fi
ocaisa commented 1 day ago

So this needs an adjustment in the check for creating these, in fact they shouldn't be touched at all by GPU PRs

ocaisa commented 1 day ago

Well, there's no check I think, we just create and if they are different they are picked up so we just need to chomp off accel/nvidia/cc80 in the target path (if it exists)