search

EEXCESS / eexcess

This is the EEXCESS main repository bringing togehter the different sub-projects and providing the documentation in the Wiki. Its the starting point when you want to know more about the project.
http://eexcess.eu/
5 stars 2 forks source link

language information of a documentBadge doesn't match the description #18

Open pstoehr opened 8 years ago

pstoehr commented 8 years ago

The documentation state that language information is returned as ISO 639-1 formatted string.

In some results returned from a /recommand api-call a lot of white-spaces, namely \t or \n, are added to the result.

Examples: "documentBadge": { "id": "224cf6a0-d075-45ed-980e-193654474cfc", "uri": "http:\/\/culture.joanneum.at\/catalog\/online-katalog\/?detail=224cf6a0-d075-45ed-980e-193654474cfc", "provider": "\n\t\t\t\t\t\t\t\tKierling\n\t\t\t\t\t\t\t" }, "mediaType": "text", "title": "Probedruck, Priester mit Monstranz ", "description": "\"Sel. Peter Julian\"", "date": "unknown", "language": "\n\t\t\t\t\t\tde\n\t\t\t\t\t", "licence": "\n\t\t\t\t\t\thttp:\/\/creativecommons.org\/licenses\/by-nc-sa\/4.0\/\n\t\t\t\t\t", "generatingQuery": "(Peter)" },

"documentBadge": { "id": "SK-A-133", "uri": "https:\/\/www.rijksmuseum.nl\/en\/collection\/SK-A-133", "provider": "\n\t\t\t\t\t\t\t\tRijksMuseum\n\t\t\t\t\t\t\t" }, "mediaType": "text", "title": "Portrait of a Couple, Probably Isaac Abrahamsz Massa and Beatrix van der Laen", "description": "Portrait of a Couple, Probably Isaac Abrahamsz Massa and Beatrix van der Laen, Frans Hals, c. 1622", "date": "unknown", "language": "\n\t\t\t\t\t\tde\n\t\t\t\t\t", "licence": "\n\t\t\t\t\t\thttp:\/\/creativecommons.org\/licenses\/by-nc-sa\/4.0\/\n\t\t\t\t\t", "generatingQuery": "(Peter)" },

Is the client supposed to remove the whitespaces?

Endpoint for the queries: https://eexcess-dev.joanneum.at/eexcess-privacy-proxy-issuer-1.0-SNAPSHOT/issuer

chseifert commented 8 years ago

Thomas, could you have a look on this. Seems to me part of the metadata mapping component.

jr-dig-orgel commented 8 years ago

I have fixed this issue, and now the whitespaces should not appear anymore.

pstoehr commented 8 years ago

Would it be possible to remove the unneeded white spaces from all other strings too?

"result": [ { "resultGroup": [

  ],
  "documentBadge": {
    "id": "B1.27872",
    "uri": "https:\/\/www.kgportal.bl.ch\/sammlungen#6e6ac78d-4098-9cc9-8cdb-1dbfb88c3344",
    "provider": "KIMPortal"
  },
  "mediaType": "text",
  "title": "Planta indeterminata",
  "date": "unknown",
  "language": "de",
  "licence": "http:\/\/creativecommons.org\/licenses\/by-nc-sa\/4.0\/\n\t\t\t\t\t\t\t",
  "generatingQuery": "Peter"
},

Compared to one of the buggy results from yesterday where all whitespaces are removed { "resultGroup": [

  ],
  "documentBadge": {
    "id": "224cf6a0-d075-45ed-980e-193654474cfc",
    "uri": "http:\/\/culture.joanneum.at\/catalog\/online-katalog\/?detail=224cf6a0-d075-45ed-980e-193654474cfc",
    "provider": "Kierling"
  },
  "mediaType": "text",
  "title": "Probedruck, Priester mit Monstranz ",
  "description": "\\\"Sel. Peter Julian\\\"",
  "date": "unknown",
  "language": "de",
  "licence": "http:\/\/creativecommons.org\/licenses\/by-nc-sa\/4.0\/",
  "generatingQuery": "(Peter)"
},
chseifert commented 8 years ago

Reopened, because of similar behaviour in other fields.

jr-dig-orgel commented 8 years ago

I have pushed a new version - in the next version hopefully all whitespaces show be removed