search

EFForg / OpenWireless

The official home of the EFF OpenWireless Project
Other
732 stars 80 forks source link

Replace make-templates.sh with Makefile #233

Closed fawkesley closed 10 years ago

fawkesley commented 10 years ago

Beginnings of a Makefile which provides the following:

make app/js/templates.js
make all
make clean

make assert_templates_js_up_to_date

Note that I preserved the principle of generating a temporary file with handlebars then moving it into place (which I presume was for atomicity). However the tempfile is now generated by mktemp which is safer than using the PID to derive a name.

Starts #227

Rangak commented 10 years ago

Thanks for getting this started ! Let me know if you are planning to tackle build.sh as well to build the router firmware. I will hold of on checking in a rebuild.sh as that was just a hack until we had real Makefiles.

jsha commented 10 years ago

On the whole, great change, thanks! Just the one comment above.

fawkesley commented 10 years ago

@jsha Ah now I understand that one. See related PR https://github.com/EFForg/OpenWireless/pull/234 - have I missed the point on why templates.js is checked in? (it doesn't seem to me like it should be)

fawkesley commented 10 years ago

@Rangak Will do!

fawkesley commented 10 years ago

@jsha I've brought this back in line with how it was working before and made a big comment near the Makefile target explaining the workaround. Hopefully that works for all scenarios :)

jsha commented 10 years ago

Thanks!

fawkesley commented 10 years ago

Pleasure!

— Sent from mobile

On Mon, Aug 18, 2014 at 5:48 PM, jsha notifications@github.com wrote:

Thanks!

Reply to this email directly or view it on GitHub: https://github.com/EFForg/OpenWireless/pull/233#issuecomment-52520164