This is 2 major versions above what's on master right now, so worth giving it a closer review.
I added some feature tests (spec/features/ahoy.rb) to ensure we're only collecting what we were before, but they're a bit brittle...there's a timing issue where sometimes the event isn't fully persisted before we check expectations. Switching the expectation to be based on the user's page (where we show actions they've taken if they've enabled activity recording) might work, but we still have to check the DB exclusively for one of the cases so it's not a full fix.
This is 2 major versions above what's on
masterright now, so worth giving it a closer review.I added some feature tests (
spec/features/ahoy.rb) to ensure we're only collecting what we were before, but they're a bit brittle...there's a timing issue where sometimes the event isn't fully persisted before we check expectations. Switching the expectation to be based on the user's page (where we show actions they've taken if they've enabled activity recording) might work, but we still have to check the DB exclusively for one of the cases so it's not a full fix.